From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next 2/2] bnx2x: use the default NAPI weight
Date: Tue, 05 Mar 2013 19:28:29 -0800 [thread overview]
Message-ID: <1362540509.15793.158.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130305.210909.1826827522208936437.davem@davemloft.net>
On Tue, 2013-03-05 at 21:09 -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 05 Mar 2013 17:57:47 -0800
>
> > BQL (Byte Queue Limits) proper operation needs TX completion
> > being serviced in a timely fashion.
> >
> > bnx2x uses a non standard NAPI poll weight, and thats not fair to other
> > napi poll handlers, and even not reasonable.
>
> Can you give some details about the situation in which you noticed
> this?
>
> It may be reason enough to target this for 'net' and -stable instead.
Sure :
We are facing a fanout/fanin problem for a given application.
What happens is that link is mostly idle, and every couple of minutes,
we receive a burst of messages, needing a burst of transmits.
BQL starts with a limit of 0, meaning it needs some TX completion runs
to be able to detect the sudden increase of TX need and reach line rate.
bnx2x is really unfair in this scenario, because the NAPI poll budget is
very high, and aggregated packets (by LRO) count for a single packet in
the budget. (or even 0, see the "goto next_cqe;" that avoids the rx_pkt
++; in drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c line 1007)
We probably have other issues in the stack, I am patiently finding all
of them. In the mean time we had to disable BQL :(
next prev parent reply other threads:[~2013-03-06 3:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 1:57 [PATCH net-next 2/2] bnx2x: use the default NAPI weight Eric Dumazet
2013-03-06 2:09 ` David Miller
2013-03-06 3:28 ` Eric Dumazet [this message]
2013-03-06 4:37 ` David Miller
2013-03-06 7:03 ` Eric Dumazet
2013-03-06 19:59 ` David Miller
2013-03-06 21:52 ` Eric Dumazet
2013-03-10 8:38 ` Herbert Xu
2013-03-11 6:14 ` Eric Dumazet
2013-03-06 4:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362540509.15793.158.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox