From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, eilong@broadcom.com, jhs@mojatatu.com,
Tom Herbert <therbert@google.com>
Subject: Re: [PATCH net-next 2/2] bnx2x: use the default NAPI weight
Date: Mon, 11 Mar 2013 07:14:57 +0100 [thread overview]
Message-ID: <1362982497.4051.37.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130310083800.GC10448@gondor.apana.org.au>
On Sun, 2013-03-10 at 16:38 +0800, Herbert Xu wrote:
> On Wed, Mar 06, 2013 at 01:52:57PM -0800, Eric Dumazet wrote:
> >
> > - BQL (incurring more TX completion rounds and possibility to
> > block/unblock a qdisc)
> > - ticket spinlocks, and even with the guard of qdisc busylock
> >
> > -> we can have a starvation problem.
>
> This only happens in cases where we aren't using multiqueue or
> we're using it incorrectly, resulting in TX work from being split
> over CPUs.
>
Or using qdisc like HTB ;)
> In that case it's not clear that it is starvation if we keep the
> TX processing on one CPU.
Thats not always the case. TX path has interesting features like XPS ...
We probably could add instrumentation and keep track of the maximum time
we are spending in this dark area.
next prev parent reply other threads:[~2013-03-11 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 1:57 [PATCH net-next 2/2] bnx2x: use the default NAPI weight Eric Dumazet
2013-03-06 2:09 ` David Miller
2013-03-06 3:28 ` Eric Dumazet
2013-03-06 4:37 ` David Miller
2013-03-06 7:03 ` Eric Dumazet
2013-03-06 19:59 ` David Miller
2013-03-06 21:52 ` Eric Dumazet
2013-03-10 8:38 ` Herbert Xu
2013-03-11 6:14 ` Eric Dumazet [this message]
2013-03-06 4:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362982497.4051.37.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox