From: Georg Hofmann <georg@hofmannsweb.com>
To: netdev@vger.kernel.org
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com, davem@davemloft.net
Subject: [PATCH 3.9-rc2] net: fec: fix missing napi_disable call
Date: Thu, 14 Mar 2013 17:54:09 +0100 [thread overview]
Message-ID: <1363280049.3967.21.camel@gh-dell> (raw)
Commit dc975382d2ef36be7e78fac3717927de1a5abcd8 introduces napi support
but never calls napi_disable. This will generate a kernel oops
(kernel BUG at include/linux/netdevice.h:473!) every time, when
ndo_stop is called followed by ndo_start.
Add the missing napi_diable call.
Signed-off-by: Georg Hofmann <georg@hofmannsweb.com>
---
Tested with a imx28-evk board.
drivers/net/ethernet/freescale/fec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index 069a155..128da16 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -1437,6 +1437,7 @@ fec_enet_close(struct net_device *ndev)
struct fec_enet_private *fep = netdev_priv(ndev);
/* Don't know what to do yet. */
+ napi_disable(&fep->napi);
fep->opened = 0;
netif_stop_queue(ndev);
fec_stop(ndev);
next reply other threads:[~2013-03-14 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 16:54 Georg Hofmann [this message]
2013-03-15 12:47 ` [PATCH 3.9-rc2] net: fec: fix missing napi_disable call David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363280049.3967.21.camel@gh-dell \
--to=georg@hofmannsweb.com \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox