* [PATCH 3.9-rc2] net: fec: fix missing napi_disable call
@ 2013-03-14 16:54 Georg Hofmann
2013-03-15 12:47 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Georg Hofmann @ 2013-03-14 16:54 UTC (permalink / raw)
To: netdev; +Cc: grant.likely, rob.herring, davem
Commit dc975382d2ef36be7e78fac3717927de1a5abcd8 introduces napi support
but never calls napi_disable. This will generate a kernel oops
(kernel BUG at include/linux/netdevice.h:473!) every time, when
ndo_stop is called followed by ndo_start.
Add the missing napi_diable call.
Signed-off-by: Georg Hofmann <georg@hofmannsweb.com>
---
Tested with a imx28-evk board.
drivers/net/ethernet/freescale/fec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index 069a155..128da16 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -1437,6 +1437,7 @@ fec_enet_close(struct net_device *ndev)
struct fec_enet_private *fep = netdev_priv(ndev);
/* Don't know what to do yet. */
+ napi_disable(&fep->napi);
fep->opened = 0;
netif_stop_queue(ndev);
fec_stop(ndev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-15 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-14 16:54 [PATCH 3.9-rc2] net: fec: fix missing napi_disable call Georg Hofmann
2013-03-15 12:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox