public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: dormando <dormando@rydia.net>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: BUG: IPv4: Attempt to release TCP socket in state 1
Date: Thu, 14 Mar 2013 23:56:26 +0100	[thread overview]
Message-ID: <1363301786.29475.40.camel@edumazet-glaptop> (raw)
In-Reply-To: <alpine.DEB.2.02.1303141359080.16308@dflat>

On Thu, 2013-03-14 at 14:21 -0700, dormando wrote:
> >
> > diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
> > index 68f6a94..1d4d97e 100644
> > --- a/net/ipv4/af_inet.c
> > +++ b/net/ipv4/af_inet.c
> > @@ -141,8 +141,9 @@ void inet_sock_destruct(struct sock *sk)
> >  	sk_mem_reclaim(sk);
> >
> >  	if (sk->sk_type == SOCK_STREAM && sk->sk_state != TCP_CLOSE) {
> > -		pr_err("Attempt to release TCP socket in state %d %p\n",
> > -		       sk->sk_state, sk);
> > +		pr_err("Attempt to release TCP socket family %d in state %d %p\n",
> > +		       sk->sk_family, sk->sk_state, sk);
> > +		WARN_ON_ONCE(1);
> >  		return;
> >  	}
> >  	if (!sock_flag(sk, SOCK_DEAD)) {
> 
> [58377.436522] IPv4: Attempt to release TCP socket family 2 in state 1
> ffff8813fbad9500

There is no stack information on the WARN_ON_ONCE(1) ?

  reply	other threads:[~2013-03-14 22:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.DEB.2.02.1303041547080.7811@localhost6.localdomain6>
2013-03-05  3:47 ` BUG: IPv4: Attempt to release TCP socket in state 1 Cong Wang
2013-03-05  5:07   ` Eric Dumazet
2013-03-05  5:44     ` dormando
2013-03-05 14:46       ` Eric Dumazet
2013-03-07  0:41         ` dormando
2013-03-07 13:46           ` Eric Dumazet
2013-03-08  7:09             ` dormando
2013-03-14 21:21             ` dormando
2013-03-14 22:56               ` Eric Dumazet [this message]
2013-03-14 23:15                 ` dormando
2013-03-14 23:19                   ` Eric Dumazet
2013-03-16 17:36                     ` Eric Dumazet
2013-03-16 17:44                       ` Eric Dumazet
2013-03-16 20:16                         ` dormando
2013-03-17  9:21                         ` dormando
2013-03-17 16:33                           ` Eric Dumazet
2013-03-17 16:52                             ` Eric Dumazet
2013-03-17 19:00                               ` Eric Dumazet
2013-03-17  6:39                       ` Hannes Frederic Sowa
2013-03-17  7:53                         ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363301786.29475.40.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=dormando@rydia.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox