From: Eric Dumazet <eric.dumazet@gmail.com>
To: dormando <dormando@rydia.net>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: BUG: IPv4: Attempt to release TCP socket in state 1
Date: Sun, 17 Mar 2013 09:52:49 -0700 [thread overview]
Message-ID: <1363539169.29475.78.camel@edumazet-glaptop> (raw)
In-Reply-To: <1363538008.29475.73.camel@edumazet-glaptop>
On Sun, 2013-03-17 at 09:33 -0700, Eric Dumazet wrote:
> On Sun, 2013-03-17 at 02:21 -0700, dormando wrote:
>
> > Hope you don't mind a screenshot:
> > http://www.dormando.me/p/3.8.2-trace-crash.jpg
> >
> > (I put the patches on 3.8.2). box is on another continent so screenshot
> > via IPMI is what I get. If this isn't enough or isn't right I'll try
> > harder to get the trace logged, I guess?
>
> Thanks a lot, this gives another useful input, no need for more traces
> for the moment.
>
> Could you send me the disassembly of tcp_release_cb() ?
>
> (objdump -d vmlinux | filter to get tcp_release_cb() body)
>
>
It seems we can have a refcnt imbalance because of
atomic_set(&newsk->sk_refcnt, 2);
we do in sk_clone_lock()
Somehow, something is wrong, because at this point the socket should not
be found.
We perform a sock_hold() somewhere while the socket is already dead.
I'll send a patch asap
next prev parent reply other threads:[~2013-03-17 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.02.1303041547080.7811@localhost6.localdomain6>
2013-03-05 3:47 ` BUG: IPv4: Attempt to release TCP socket in state 1 Cong Wang
2013-03-05 5:07 ` Eric Dumazet
2013-03-05 5:44 ` dormando
2013-03-05 14:46 ` Eric Dumazet
2013-03-07 0:41 ` dormando
2013-03-07 13:46 ` Eric Dumazet
2013-03-08 7:09 ` dormando
2013-03-14 21:21 ` dormando
2013-03-14 22:56 ` Eric Dumazet
2013-03-14 23:15 ` dormando
2013-03-14 23:19 ` Eric Dumazet
2013-03-16 17:36 ` Eric Dumazet
2013-03-16 17:44 ` Eric Dumazet
2013-03-16 20:16 ` dormando
2013-03-17 9:21 ` dormando
2013-03-17 16:33 ` Eric Dumazet
2013-03-17 16:52 ` Eric Dumazet [this message]
2013-03-17 19:00 ` Eric Dumazet
2013-03-17 6:39 ` Hannes Frederic Sowa
2013-03-17 7:53 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363539169.29475.78.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=dormando@rydia.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox