From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dmitry Kravkov <dmitry@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
"Eilon Greenstein" <eilong@broadcom.com>,
"Tom Herbert" <therbert@google.com>,
"Maciej Żenczykowski" <maze@google.com>
Subject: Re: [PATCH net-next 2/2] bnx2x: add RSS capability for GRE traffic
Date: Mon, 18 Mar 2013 17:07:52 -0700 [thread overview]
Message-ID: <1363651672.21184.17.camel@edumazet-glaptop> (raw)
In-Reply-To: <1363625464-21633-2-git-send-email-dmitry@broadcom.com>
On Mon, 2013-03-18 at 18:51 +0200, Dmitry Kravkov wrote:
> The patch drives FW to perform RSS for GRE traffic,
> based on inner headers.
>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 3 +++
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 23 ++++++++++++-----------
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.h | 9 +++++++++
> 3 files changed, 24 insertions(+), 11 deletions(-)
This works very well.
Problem is we skb_set_queue_mapping(skb, 0); in __skb_tunnel_rx()
(this was a patch from Tom Herbert, commit
693019e90ca45d881109d32c0c6d29adf03f6447 (net: reset skb queue mapping
when rx'ing over tunnel )
Meaning we hit a single cpu for the GRO stuff in ip_gre.
I have to think about it.
Another question is :
Can bnx2x check the tcp checksum if GRE encapsulated ?
next prev parent reply other threads:[~2013-03-19 0:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 16:51 [PATCH net-next 1/2] bnx2x: add CSUM and TSO support for encapsulation protocols Dmitry Kravkov
2013-03-18 16:51 ` [PATCH net-next 2/2] bnx2x: add RSS capability for GRE traffic Dmitry Kravkov
2013-03-18 17:11 ` David Miller
2013-03-19 0:07 ` Eric Dumazet [this message]
2013-03-19 6:30 ` Dmitry Kravkov
2013-03-19 9:18 ` Maciej Żenczykowski
2013-03-19 12:21 ` Dmitry Kravkov
2013-03-19 12:25 ` Eric Dumazet
2013-03-19 13:43 ` Dmitry Kravkov
2013-08-17 17:53 ` Jerry Chu
2013-08-17 18:52 ` Dmitry Kravkov
2013-08-17 19:01 ` Eric Dumazet
2013-08-17 19:04 ` Dmitry Kravkov
2013-08-18 11:55 ` Jerry Chu
2013-08-18 15:37 ` Eric Dumazet
2013-08-18 21:11 ` Jerry Chu
2013-08-18 23:44 ` Eric Dumazet
2013-08-19 14:57 ` Jerry Chu
2013-03-18 17:11 ` [PATCH net-next 1/2] bnx2x: add CSUM and TSO support for encapsulation protocols David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363651672.21184.17.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox