From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jerry Chu <hkchu@google.com>
Cc: "Dmitry Kravkov" <dkravkov@gmail.com>,
"Dmitry Kravkov" <dmitry@broadcom.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Eilon Greenstein" <eilong@broadcom.com>,
"Tom Herbert" <therbert@google.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Uday Naik" <uday@google.com>,
"Michael Dalton" <mwdalton@google.com>
Subject: Re: [PATCH net-next 2/2] bnx2x: add RSS capability for GRE traffic
Date: Sun, 18 Aug 2013 16:44:53 -0700 [thread overview]
Message-ID: <1376869493.4226.13.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAPshTCjB9S-Xc4MTs5XXLm6N=0-v_9gxC2SDwCzieTc4Py43fg@mail.gmail.com>
On Sun, 2013-08-18 at 14:11 -0700, Jerry Chu wrote:
> It can if the csum validation is deferred. But this requires the stack code to
> aggregate csum from individual pkt header, which can get ugly as one needs
> to remove the header part from the individual csum first.
You can _not_ aggregate packets _before_ validating their checksum, or
else you could end up with a correct final checksum while two or more
segments had buggy checksums. Checksum are already quite weak, please
do not make them even weaker ;)
GRO should not throw out any segments, it is not its role.
If a router receives a bunch of packets, it should forward them
regardless of the (TCP) checksum being good or not.
The final receiver has full responsibility for ultimately validate the
checksums and update various SNMP counters.
next prev parent reply other threads:[~2013-08-18 23:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 16:51 [PATCH net-next 1/2] bnx2x: add CSUM and TSO support for encapsulation protocols Dmitry Kravkov
2013-03-18 16:51 ` [PATCH net-next 2/2] bnx2x: add RSS capability for GRE traffic Dmitry Kravkov
2013-03-18 17:11 ` David Miller
2013-03-19 0:07 ` Eric Dumazet
2013-03-19 6:30 ` Dmitry Kravkov
2013-03-19 9:18 ` Maciej Żenczykowski
2013-03-19 12:21 ` Dmitry Kravkov
2013-03-19 12:25 ` Eric Dumazet
2013-03-19 13:43 ` Dmitry Kravkov
2013-08-17 17:53 ` Jerry Chu
2013-08-17 18:52 ` Dmitry Kravkov
2013-08-17 19:01 ` Eric Dumazet
2013-08-17 19:04 ` Dmitry Kravkov
2013-08-18 11:55 ` Jerry Chu
2013-08-18 15:37 ` Eric Dumazet
2013-08-18 21:11 ` Jerry Chu
2013-08-18 23:44 ` Eric Dumazet [this message]
2013-08-19 14:57 ` Jerry Chu
2013-03-18 17:11 ` [PATCH net-next 1/2] bnx2x: add CSUM and TSO support for encapsulation protocols David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376869493.4226.13.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dkravkov@gmail.com \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=hkchu@google.com \
--cc=maze@google.com \
--cc=mwdalton@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=uday@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox