From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: tingwei liu <tingw.liu@gmail.com>, <netdev@vger.kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, <davem@davemloft.net>
Subject: Re: [PATCH 1/1]core:Change a wrong explain about dev_get_by_name
Date: Wed, 20 Mar 2013 17:10:43 +0000 [thread overview]
Message-ID: <1363799443.2677.2.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1363793549.3333.12.camel@edumazet-glaptop>
On Wed, 2013-03-20 at 08:32 -0700, Eric Dumazet wrote:
> On Wed, 2013-03-20 at 17:33 +0800, tingwei liu wrote:
> > From 5d787e8c3725efa6af3036eeb52aba1905c70de9 Mon Sep 17 00:00:00 2001
> > From: root <root@linux-19.site>
> > Date: Wed, 20 Mar 2013 17:39:59 +0800
> > Subject: [PATCH] Change a wrong explain about dev_get_by_name
> >
>
> No changelog ? This patch really needs a changelog.
>
> I have no idea why we should document this function being not safe in
> irq context.
>
> Most part of networking stack is non safe in hard irq context.
>
> Should we add a comment in front of all possible entry points ?
If they are wrongly documented as 'can be called from any context', yes.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-03-20 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 9:33 [PATCH 1/1]core:Change a wrong explain about dev_get_by_name tingwei liu
2013-03-20 15:32 ` Eric Dumazet
2013-03-20 17:10 ` Ben Hutchings [this message]
2013-03-20 17:43 ` Eric Dumazet
2013-03-23 1:24 ` tingwei liu
2013-03-23 1:32 ` Eric Dumazet
2013-03-24 7:07 ` tingwei liu
2013-03-23 1:33 ` tingwei liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363799443.2677.2.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=tingw.liu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox