From: Eric Dumazet <eric.dumazet@gmail.com>
To: tingwei liu <tingw.liu@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
davem@davemloft.net
Subject: Re: [PATCH 1/1]core:Change a wrong explain about dev_get_by_name
Date: Fri, 22 Mar 2013 18:32:04 -0700 [thread overview]
Message-ID: <1364002324.4431.84.camel@edumazet-glaptop> (raw)
In-Reply-To: <CA+qZnST22XrkFgsNqE8aAziD++4EZXzBGzM-4GNbbxfi8z+yvQ@mail.gmail.com>
On Sat, 2013-03-23 at 09:24 +0800, tingwei liu wrote:
> On Thu, Mar 21, 2013 at 1:43 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > On Wed, 2013-03-20 at 17:10 +0000, Ben Hutchings wrote:
> >
> >> If they are wrongly documented as 'can be called from any context', yes.
> >
> > Wow, thats really useful.
> >
> > Why is this function not allowed from hard irq context, we have no idea.
> When function "list_netdevice" get write lock "dev_base_lock" only
> disable soft interrupt. So dev_get_by_name get read lock
> "dev_base_lock", can not called on interrupt context.
dev_get_by_name() doesn't read lock dev_base_lock
since commit 72c9528bab94cc052
This was back to linux-2.6.33
Are you sending patches for older kernel versions per chance ?
next prev parent reply other threads:[~2013-03-23 1:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 9:33 [PATCH 1/1]core:Change a wrong explain about dev_get_by_name tingwei liu
2013-03-20 15:32 ` Eric Dumazet
2013-03-20 17:10 ` Ben Hutchings
2013-03-20 17:43 ` Eric Dumazet
2013-03-23 1:24 ` tingwei liu
2013-03-23 1:32 ` Eric Dumazet [this message]
2013-03-24 7:07 ` tingwei liu
2013-03-23 1:33 ` tingwei liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364002324.4431.84.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=tingw.liu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox