From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] fec: Use SIMPLE_DEV_PM_OPS
Date: Tue, 16 Apr 2013 10:49:05 -0700 [thread overview]
Message-ID: <1366134545.28609.1.camel@joe-AO722> (raw)
In-Reply-To: <516D8649.4030604@cogentembedded.com>
On Tue, 2013-04-16 at 21:11 +0400, Sergei Shtylyov wrote:
> On 16-04-2013 19:22, Fabio Estevam wrote:
> >>> +static SIMPLE_DEV_PM_OPS(fec_pm_ops, fec_suspend, fec_resume);
> >>> +#define FEC_PM_OPS (&fec_pm_ops)
> >> Nit: parens are useless here.
Is this macro indirection even useful?
Using &fec_pm_ops seems quite readable.
next prev parent reply other threads:[~2013-04-16 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 13:58 [PATCH] fec: Use SIMPLE_DEV_PM_OPS Fabio Estevam
2013-04-16 14:32 ` Sergei Shtylyov
2013-04-16 15:22 ` Fabio Estevam
2013-04-16 17:11 ` Sergei Shtylyov
2013-04-16 17:49 ` Joe Perches [this message]
2013-04-16 17:51 ` Fabio Estevam
2013-04-16 21:25 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366134545.28609.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox