From: Eric Dumazet <eric.dumazet@gmail.com>
To: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: netdev@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH][net-next] gianfar: Fix reported sent bytes to BQL for Tx timestamping
Date: Mon, 29 Apr 2013 08:33:48 -0700 [thread overview]
Message-ID: <1367249628.8964.316.camel@edumazet-glaptop> (raw)
In-Reply-To: <1367249009.8964.312.camel@edumazet-glaptop>
On Mon, 2013-04-29 at 08:23 -0700, Eric Dumazet wrote:
> > Does BQL really need to measure the bytes-on-wire or the bytes consumed
> > for buffering?
>
> Yes.
I meant, bytes on wire.
If it was bytes consumed for buffering, we would use skb->truesize here.
Anyway, I am not sure your fix is enough if VLAN is used for example.
prev parent reply other threads:[~2013-04-29 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 12:57 [PATCH][net-next] gianfar: Fix reported sent bytes to BQL for Tx timestamping Claudiu Manoil
2013-04-29 13:53 ` Eric Dumazet
2013-04-29 14:27 ` Claudiu Manoil
2013-04-29 15:23 ` Eric Dumazet
2013-04-29 15:28 ` Eric Dumazet
2013-04-29 15:39 ` Eric Dumazet
2013-04-29 15:42 ` Eric Dumazet
2013-04-29 15:52 ` Claudiu Manoil
2013-04-29 15:59 ` Eric Dumazet
2013-08-30 12:01 ` [PATCH][net-next] gianfar: Fix reported number of sent bytes to BQL Claudiu Manoil
2013-09-03 18:59 ` Florian Fainelli
2013-09-03 19:18 ` Florian Fainelli
2013-09-04 2:14 ` David Miller
2013-04-29 15:33 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367249628.8964.316.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox