From: Eric Dumazet <eric.dumazet@gmail.com>
To: Benjamin Poirier <bpoirier@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Pavel Emelyanov <xemul@parallels.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] unix/dgram: fix peeking with an offset larger than data in queue
Date: Mon, 29 Apr 2013 17:49:54 -0700 [thread overview]
Message-ID: <1367282994.8964.335.camel@edumazet-glaptop> (raw)
In-Reply-To: <1367271734-14379-2-git-send-email-bpoirier@suse.de>
On Mon, 2013-04-29 at 17:42 -0400, Benjamin Poirier wrote:
> Currently, peeking on a unix datagram socket with an offset larger than len of
> the data in the sk receive queue returns immediately with bogus data. That's
> because *off is not reset between each skb_queue_walk().
>
> This patch fixes this so that the behavior is the same as peeking with no
> offset on an empty queue: the caller blocks.
>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
>
> ---
>
> v2: address review feedback from Eric Dumazet
>
> v3: address review feedback from Cong Wang
>
> net/core/datagram.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-04-30 0:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 13:47 [PATCH net 1/3] unix/dgram: peek beyond 0-sized skbs Benjamin Poirier
2013-04-25 13:47 ` [PATCH net 2/3] unix/dgram: fix peeking with an offset larger than data in queue Benjamin Poirier
2013-04-25 18:58 ` Eric Dumazet
2013-04-25 13:47 ` [PATCH net 3/3] unix/stream: " Benjamin Poirier
2013-04-25 18:48 ` [PATCH net 1/3] unix/dgram: peek beyond 0-sized skbs Eric Dumazet
2013-04-26 18:35 ` Benjamin Poirier
2013-04-26 18:35 ` [PATCH net v2 2/3] unix/dgram: fix peeking with an offset larger than data in queue Benjamin Poirier
2013-04-29 7:01 ` Cong Wang
2013-04-29 21:42 ` [PATCH v3 1/3] unix/dgram: peek beyond 0-sized skbs Benjamin Poirier
2013-04-29 21:42 ` [PATCH v3 2/3] unix/dgram: fix peeking with an offset larger than data in queue Benjamin Poirier
2013-04-30 0:49 ` Eric Dumazet [this message]
2013-04-30 4:44 ` David Miller
2013-04-29 21:42 ` [PATCH v3 3/3] unix/stream: " Benjamin Poirier
2013-04-30 0:51 ` Eric Dumazet
2013-04-30 4:44 ` David Miller
2013-04-30 0:48 ` [PATCH v3 1/3] unix/dgram: peek beyond 0-sized skbs Eric Dumazet
2013-04-30 4:44 ` David Miller
2013-04-26 18:35 ` [PATCH net v2 3/3] unix/stream: fix peeking with an offset larger than data in queue Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367282994.8964.335.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bpoirier@suse.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox