Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	"Jay Vosburgh" <fubar@us.ibm.com>,
	"Maciej Żenczykowski" <maze@google.com>,
	"Andy Gospodarek" <andy@greyhouse.net>,
	"Tom Herbert" <therbert@google.com>,
	"Neal Cardwell" <ncardwell@google.com>,
	"Yuchung Cheng" <ycheng@google.com>
Subject: Re: [PATCH] bonding: allow TSO being set on bonding master
Date: Wed, 15 May 2013 23:09:32 -0700	[thread overview]
Message-ID: <1368684572.3301.14.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAHXqBFLnPQnd2a17B4_UKpiL70BzkFMWzocM-4mr88TYoG6Jcw@mail.gmail.com>

On Thu, 2013-05-16 at 07:45 +0200, Michał Mirosław wrote:

> This should enable GSO if at least one slave has it on. What features
> (tx-tcp*) the slaves have?

Both slaves have tso off, gso on.

(Let's say for some tricky hardware bug on the NIC)

We want to not do tso on the NIC, but do the GSO segmentation right
before NIC.

It brings about 30% improvement.

  reply	other threads:[~2013-05-16  6:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 21:41 [PATCH] bonding: allow TSO being set on bonding master Eric Dumazet
2013-05-15 22:55 ` Michał Mirosław
2013-05-15 23:18   ` Eric Dumazet
2013-05-15 23:30     ` Eric Dumazet
2013-05-16  4:31       ` Maciej Żenczykowski
2013-05-16  4:44         ` Eric Dumazet
2013-05-16  5:45       ` Michał Mirosław
2013-05-16  6:09         ` Eric Dumazet [this message]
2013-05-16  8:59           ` Michał Mirosław
2013-05-16 17:34 ` [PATCH v2] " Eric Dumazet
2013-05-16 22:02   ` David Miller
2013-05-16 22:16     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368684572.3301.14.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=maze@google.com \
    --cc=mirqus@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox