From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: mirqus@gmail.com, netdev@vger.kernel.org, fubar@us.ibm.com,
maze@google.com, andy@greyhouse.net, therbert@google.com,
ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH v2] bonding: allow TSO being set on bonding master
Date: Thu, 16 May 2013 15:02:39 -0700 (PDT) [thread overview]
Message-ID: <20130516.150239.2187164031807939707.davem@davemloft.net> (raw)
In-Reply-To: <1368725693.3301.59.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 16 May 2013 10:34:53 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> In some situations, we need to disable TSO on bonding slaves.
>
> bonding device automatically unset TSO in bond_fix_features(), and
> performance is not good because :
>
> 1) We consume more cpu cycles.
>
> 2) GSO segmentation has some bugs leading to out of order TCP packets
> if this segmentation is done before virtual device. This particular
> problem will be addressed in a separate patch.
>
> This patch allows TSO being set/unset on the bonding master,
> so that GSO segmentation is done after bonding layer.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, but:
> +static inline netdev_features_t netdev_add_tso_features(netdev_features_t features,
> + netdev_features_t mask)
I fixed the mask argument indentation when I commited this.
Thakns.
next prev parent reply other threads:[~2013-05-16 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 21:41 [PATCH] bonding: allow TSO being set on bonding master Eric Dumazet
2013-05-15 22:55 ` Michał Mirosław
2013-05-15 23:18 ` Eric Dumazet
2013-05-15 23:30 ` Eric Dumazet
2013-05-16 4:31 ` Maciej Żenczykowski
2013-05-16 4:44 ` Eric Dumazet
2013-05-16 5:45 ` Michał Mirosław
2013-05-16 6:09 ` Eric Dumazet
2013-05-16 8:59 ` Michał Mirosław
2013-05-16 17:34 ` [PATCH v2] " Eric Dumazet
2013-05-16 22:02 ` David Miller [this message]
2013-05-16 22:16 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516.150239.2187164031807939707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=maze@google.com \
--cc=mirqus@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox