From: Eric Dumazet <eric.dumazet@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] dev: remove duplicate 'skb->dev = dev' in dev_forward_skb()
Date: Fri, 17 May 2013 06:39:12 -0700 [thread overview]
Message-ID: <1368797952.3301.85.camel@edumazet-glaptop> (raw)
In-Reply-To: <1368783392-21574-1-git-send-email-nicolas.dichtel@6wind.com>
On Fri, 2013-05-17 at 11:36 +0200, Nicolas Dichtel wrote:
> This was added by commit 59b9997baba5 (Revert "net: maintain namespace
> isolation between vlan and real device").
> In fact, before the initial commit - the one that is reverted -, this
> statement was not present.
> 'skb->dev = dev' is already done in eth_type_trans(), which is call just
> after.
>
> Spotted-by: Alain Ritoux <alain.ritoux@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-05-17 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 9:36 [PATCH] dev: remove duplicate 'skb->dev = dev' in dev_forward_skb() Nicolas Dichtel
2013-05-17 13:39 ` Eric Dumazet [this message]
2013-05-18 1:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368797952.3301.85.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox