From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org
Subject: Re: [PATCH] dev: remove duplicate 'skb->dev = dev' in dev_forward_skb()
Date: Fri, 17 May 2013 18:23:33 -0700 (PDT) [thread overview]
Message-ID: <20130517.182333.1195267149778788816.davem@davemloft.net> (raw)
In-Reply-To: <1368797952.3301.85.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 17 May 2013 06:39:12 -0700
> On Fri, 2013-05-17 at 11:36 +0200, Nicolas Dichtel wrote:
>> This was added by commit 59b9997baba5 (Revert "net: maintain namespace
>> isolation between vlan and real device").
>> In fact, before the initial commit - the one that is reverted -, this
>> statement was not present.
>> 'skb->dev = dev' is already done in eth_type_trans(), which is call just
>> after.
>>
>> Spotted-by: Alain Ritoux <alain.ritoux@6wind.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>> ---
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2013-05-18 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 9:36 [PATCH] dev: remove duplicate 'skb->dev = dev' in dev_forward_skb() Nicolas Dichtel
2013-05-17 13:39 ` Eric Dumazet
2013-05-18 1:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517.182333.1195267149778788816.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox