From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH v2 net-next] tcp: remove one indentation level in tcp_rcv_state_process()
Date: Thu, 23 May 2013 10:09:41 -0700 [thread overview]
Message-ID: <1369328981.2075.16.camel@joe-AO722> (raw)
In-Reply-To: <1369324525.3301.384.camel@edumazet-glaptop>
On Thu, 2013-05-23 at 08:55 -0700, Eric Dumazet wrote:
> Remove one level of indentation 'introduced' in commit
> c3ae62af8e75 (tcp: should drop incoming frames without ACK flag set)
[]
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
[]
> - if (sk->sk_socket)
> - sk_wake_async(sk,
> - SOCK_WAKE_IO, POLL_OUT);
[]
> + if (sk->sk_socket)
> + sk_wake_async(sk,
> + SOCK_WAKE_IO, POLL_OUT);
It'd also be nice to reflow the lines to 80 cols.
sk_wake_async(sk, SOCK_WAKE_IO, POLL_OUT);
next prev parent reply other threads:[~2013-05-23 17:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 3:16 [PATCH net-next] tcp: remove one indentation level in tcp_rcv_state_process() Eric Dumazet
2013-04-19 17:04 ` Eric Dumazet
2013-04-19 18:22 ` David Miller
2013-05-23 15:55 ` [PATCH v2 " Eric Dumazet
2013-05-23 17:09 ` Joe Perches [this message]
2013-05-23 17:12 ` Eric Dumazet
2013-05-25 1:03 ` [PATCH v3 " Eric Dumazet
2013-05-25 4:02 ` [PATCH net-next 1/2] tcp: Remove another indentation level in tcp_rcv_state_process Joe Perches
2013-05-25 4:06 ` [PATCH net-next 2/2] tcp: Remove 2 indentation levels " Joe Perches
2013-05-26 6:23 ` David Miller
2013-05-25 4:24 ` [PATCH net-next 1/2] tcp: Remove another indentation level " Eric Dumazet
2013-05-25 4:36 ` [PATCH net-next 1/2 V2] " Joe Perches
2013-05-26 6:23 ` David Miller
2013-05-26 6:23 ` [PATCH v3 net-next] tcp: remove one indentation level in tcp_rcv_state_process() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369328981.2075.16.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox