Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH net-next 1/2] tcp: Remove another indentation level in tcp_rcv_state_process
Date: Fri, 24 May 2013 21:24:58 -0700	[thread overview]
Message-ID: <1369455898.3301.466.camel@edumazet-glaptop> (raw)
In-Reply-To: <1369454556.2080.4.camel@joe-AO722>

On Fri, 2013-05-24 at 21:02 -0700, Joe Perches wrote:
> case TCP_SYN_RECV: can have an indentation level removed
> by converting:
> 
> 	if (acceptable) {
> 		[...];
> 	} else {
> 		return 1;
> 	}
> 
> to
> 	if (!acceptable)
> 		return 1;
> 	[...];
> 
> Reflow comments to fit 80 columns.
> 
> A neatening only patch.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---

> +		tp->snd_wnd = ntohs(th->window) <<
> +			tp->rx_opt.snd_wscale;

single line ?

  parent reply	other threads:[~2013-05-25  4:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  3:16 [PATCH net-next] tcp: remove one indentation level in tcp_rcv_state_process() Eric Dumazet
2013-04-19 17:04 ` Eric Dumazet
2013-04-19 18:22   ` David Miller
2013-05-23 15:55 ` [PATCH v2 " Eric Dumazet
2013-05-23 17:09   ` Joe Perches
2013-05-23 17:12     ` Eric Dumazet
2013-05-25  1:03   ` [PATCH v3 " Eric Dumazet
2013-05-25  4:02     ` [PATCH net-next 1/2] tcp: Remove another indentation level in tcp_rcv_state_process Joe Perches
2013-05-25  4:06       ` [PATCH net-next 2/2] tcp: Remove 2 indentation levels " Joe Perches
2013-05-26  6:23         ` David Miller
2013-05-25  4:24       ` Eric Dumazet [this message]
2013-05-25  4:36         ` [PATCH net-next 1/2 V2] tcp: Remove another indentation level " Joe Perches
2013-05-26  6:23           ` David Miller
2013-05-26  6:23     ` [PATCH v3 net-next] tcp: remove one indentation level in tcp_rcv_state_process() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369455898.3301.466.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox