Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h

[Joe Perches <joe@perches.com>]

On Sat, 2013-06-01 at 10:05 +0900, Lorenzo Colitti wrote:
> Reduce the indentation of most of the functions and make it a
> bit more consistent. This allows longer function and arg names
> to be consistently indented without wrapping.
[]
> diff --git a/include/net/transp_v6.h b/include/net/transp_v6.h
[]
> @@ -7,47 +7,47 @@
[]
>  /* extension headers */
> -extern int				ipv6_exthdrs_init(void);
[]
> +extern int		ipv6_exthdrs_init(void);

externs aren't useful here and I suggest prototypes like
int ipv6_exthdrs_init(void);

> -extern int			ip6_datagram_send_ctl(struct net *net,
> -						      struct sock *sk,
> -						      struct msghdr *msg,
> -						      struct flowi6 *fl6,
> -						      struct ipv6_txoptions *opt,
> -						      int *hlimit, int *tclass,
> -						      int *dontfrag);
[]
> +extern int		ip6_datagram_send_ctl(struct net *net,
> +					      struct sock *sk,
> +					      struct msghdr *msg,
> +					      struct flowi6 *fl6,
> +					      struct ipv6_txoptions *opt,
> +					      int *hlimit, int *tclass,
> +					      int *dontfrag);

int ip6_datagram_send_ctl(struct net *net, struct sock *sk, struct msghdr *msg,
			  struct flowi6 *fl6, struct ipv6_txoptions *opt,
			  int *hlimit, int *tclass, int *dontfrag);

etc...

kernel_doc might be nice too