Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
	Vasiliy Kulikov <segoon@openwall.com>
Subject: Re: [PATCH net-next post Lorenzo] transp_v6.h: style neatening
Date: Sun, 02 Jun 2013 19:34:23 -0700	[thread overview]
Message-ID: <1370226863.2096.19.camel@joe-AO722> (raw)
In-Reply-To: <CAKD1Yr3hBQWATGwqoxwdMhcrp4wSOXUzE4Kfi2XvmEFkidOJkA@mail.gmail.com>

On Mon, 2013-06-03 at 11:20 +0900, Lorenzo Colitti wrote:
> On Mon, Jun 3, 2013 at 2:04 AM, Joe Perches <joe@perches.com> wrote:
> >> I don't have strong feelings about indentation, but if possible I
> >> would like to avoid re-spinning this patchset more than twice over
> >> formatting changes to this file.
> >
> > You could do nothing and David could apply this if
> > he wants a more complete neatening.
> 
> Joe, thanks for saving me a respin. I'd have been happy to do it
> myself too, it's just that I'm a bit confused on what the style
> actually needs to be.

For now, it's whatever style David wants it to be.

A lot of the net/ code was written before more standardized
coding styles were generally settled upon for networking
and the older code is much less standardized.

It's going to be a tradeoff between "churn" in code that
doesn't have to change much at all and whatever patch rate
for whitespace style conformity David decides to accept.

> I take it you'd like me to make the new patch use
> this indentation?

Well, I would, but David will chime in eventually.

  reply	other threads:[~2013-06-03  2:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  1:05 [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h Lorenzo Colitti
2013-06-01  1:05 ` [PATCH v4 2/4] net: ipv6: Unify {raw,udp}6_sock_seq_show Lorenzo Colitti
2013-06-04 19:56   ` David Miller
2013-06-01  1:05 ` [PATCH v4 3/4] net: ipv4: make the ping /proc code AF-independent Lorenzo Colitti
2013-06-04 19:57   ` David Miller
2013-06-01  1:05 ` [PATCH v4 4/4] net: ipv6: Implement /proc/net/icmp6 Lorenzo Colitti
2013-06-04 19:57   ` David Miller
2013-06-01  1:25 ` [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h Joe Perches
2013-06-02  2:58   ` David Miller
2013-06-02  3:06     ` Joe Perches
2013-06-02  3:44       ` Lorenzo Colitti
2013-06-02  3:52         ` Joe Perches
2013-06-02  8:29       ` David Miller
2013-06-02  9:23         ` Joe Perches
2013-06-02 10:35           ` Lorenzo Colitti
2013-06-02 17:04             ` [PATCH net-next post Lorenzo] transp_v6.h: style neatening Joe Perches
2013-06-03  2:20               ` Lorenzo Colitti
2013-06-03  2:34                 ` Joe Perches [this message]
2013-06-02 14:16           ` [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h Eric Dumazet
2013-06-02 17:30             ` Joe Perches
2013-06-04 19:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370226863.2096.19.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=segoon@openwall.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox