* 9P: hook up rdma_cancelled() into p9_rdma_trans?
@ 2013-07-15 8:44 Paul Bolle
0 siblings, 0 replies; only message in thread
From: Paul Bolle @ 2013-07-15 8:44 UTC (permalink / raw)
To: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov,
David S. Miller
Cc: v9fs-developer, netdev, linux-kernel
0) Building trans_rdma.o (in v3.11-rc1) triggers a warning:
net/9p/trans_rdma.c:594:12: warning: ‘rdma_cancelled’ defined but not used [-Wunused-function]
1) Did commit 80b45261a0 ("9P: Add cancelled() to the transport
functions.") forget to actually hook up rdma_cancelled() into
p9_rdma_trans()? Say, like this:
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 928f2bb..0c42b1c 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -732,6 +732,7 @@ static struct p9_trans_module p9_rdma_trans = {
.close = rdma_close,
.request = rdma_request,
.cancel = rdma_cancel,
+ .cancelled = rdma_cancelled,
};
/**
That (compile tested only) patch silences this warning. Is there a patch
queued to do something like this? I couldn't find it.
Paul Bolle
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-07-15 8:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15 8:44 9P: hook up rdma_cancelled() into p9_rdma_trans? Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox