From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, florz@florz.de, sesse@google.com
Subject: Re: [RFC] vlan: mask vlan prio bits
Date: Wed, 17 Jul 2013 18:08:26 -0700 [thread overview]
Message-ID: <1374109706.6097.20.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130717.175823.1205139202025326865.davem@davemloft.net>
On Wed, 2013-07-17 at 17:58 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 17 Jul 2013 10:44:34 -0700
>
> > Should we clear skb->vlan_tci in iptunnel_xmit(), or should we clear it
> > in __netif_receive_skb_core() like in this patch ?
>
> The safest thing to do is as early as possible, so yes your patch here
> doing it in __netif_receive_skb_core() looks good to me.
OK then, I'll send an official patch ;)
Thanks !
prev parent reply other threads:[~2013-07-18 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 17:44 [RFC] vlan: mask vlan prio bits Eric Dumazet
2013-07-18 0:58 ` David Miller
2013-07-18 1:08 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374109706.6097.20.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=florz@florz.de \
--cc=netdev@vger.kernel.org \
--cc=sesse@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox