public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, florz@florz.de, sesse@google.com
Subject: Re: [RFC] vlan: mask vlan prio bits
Date: Wed, 17 Jul 2013 17:58:23 -0700 (PDT)	[thread overview]
Message-ID: <20130717.175823.1205139202025326865.davem@davemloft.net> (raw)
In-Reply-To: <1374083074.6097.18.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 17 Jul 2013 10:44:34 -0700

> Should we clear skb->vlan_tci in iptunnel_xmit(), or should we clear it
> in __netif_receive_skb_core() like in this patch ?

The safest thing to do is as early as possible, so yes your patch here
doing it in __netif_receive_skb_core() looks good to me.

  reply	other threads:[~2013-07-18  0:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 17:44 [RFC] vlan: mask vlan prio bits Eric Dumazet
2013-07-18  0:58 ` David Miller [this message]
2013-07-18  1:08   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717.175823.1205139202025326865.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=florz@florz.de \
    --cc=netdev@vger.kernel.org \
    --cc=sesse@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox