public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] veth: remove hardware checksum feature
Date: Thu, 08 Aug 2013 13:16:54 -0700	[thread overview]
Message-ID: <1375993014.4004.112.camel@edumazet-glaptop> (raw)
In-Reply-To: <5203F4E6.1010701@candelatech.com>

On Thu, 2013-08-08 at 12:43 -0700, Ben Greear wrote:

> So, the question is:  Is there any time that I *should* be mucking with
> skb->ip_summed when bridging pkts from one device to another on modern
> kernels?  I'm using the ptype_all hook to grab packets, and ndo_start_xmit
> to send them, in case that matters.


ndo_start_xmit() is likely bypassing the core network fallbacks.

You might try dev_hard_start_xmit() instead

  reply	other threads:[~2013-08-08 20:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 17:20 [PATCH] veth: remove hardware checksum feature Vitaly E. Lavrov
2013-07-25 17:59 ` Eric Dumazet
2013-08-08  0:07 ` Ben Greear
2013-08-08  0:12   ` Eric Dumazet
2013-08-08  0:23     ` Ben Greear
2013-08-08  1:08       ` Eric Dumazet
2013-08-08  1:54         ` Ben Greear
2013-08-08  2:52           ` Eric Dumazet
2013-08-08 19:43             ` Ben Greear
2013-08-08 20:16               ` Eric Dumazet [this message]
2013-08-08 22:13                 ` Ben Greear
2013-08-08 22:20                   ` Ben Greear
2013-08-08 22:22                   ` Eric Dumazet
2013-08-08 22:35                     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375993014.4004.112.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox