From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] veth: remove hardware checksum feature
Date: Thu, 08 Aug 2013 15:22:11 -0700 [thread overview]
Message-ID: <1376000531.4004.136.camel@edumazet-glaptop> (raw)
In-Reply-To: <52041802.9040304@candelatech.com>
On Thu, 2013-08-08 at 15:13 -0700, Ben Greear wrote:
> Looks like it should work nicely, except it would be really
> nice if I could short-circuit the xmit_nit() part for my
> protocol handler.
>
> Think there would be any interest in allowing the ptype_all
> handlers to optionally register a direction (ie tx-only, rx-only, both)
> and have dev_queue_xmit_nit() pay attention to that?
Sure, it would also make sense to apply the BPF filter _before_ doing
the skb_clone()
Right now, we :
clone packets
-> deliver the clone to the sniffer.
sniffer eventuall drops the packet after BPF filtering.
Its trivial to test the tx/rx thing in BPF, and it's JIT code.
next prev parent reply other threads:[~2013-08-08 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 17:20 [PATCH] veth: remove hardware checksum feature Vitaly E. Lavrov
2013-07-25 17:59 ` Eric Dumazet
2013-08-08 0:07 ` Ben Greear
2013-08-08 0:12 ` Eric Dumazet
2013-08-08 0:23 ` Ben Greear
2013-08-08 1:08 ` Eric Dumazet
2013-08-08 1:54 ` Ben Greear
2013-08-08 2:52 ` Eric Dumazet
2013-08-08 19:43 ` Ben Greear
2013-08-08 20:16 ` Eric Dumazet
2013-08-08 22:13 ` Ben Greear
2013-08-08 22:20 ` Ben Greear
2013-08-08 22:22 ` Eric Dumazet [this message]
2013-08-08 22:35 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376000531.4004.136.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox