public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "David S. Miller" <davem@davemloft.net>,
	Vlad Yasevich <vyasevic@redhat.com>,
	netdev@vger.kernel.org
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Subject: [PATCH net 3/4] bridge: Fix the way the PVID is referenced
Date: Tue, 10 Sep 2013 19:37:31 +0900	[thread overview]
Message-ID: <1378809451.3988.11.camel@ubuntu-vm-makita> (raw)
In-Reply-To: <1378808874.3988.2.camel@ubuntu-vm-makita>

We are using the VLAN_TAG_PRESENT bit to detect whether the PVID is
set or not at br_get_pvid(), while we don't care about the bit in
adding/deleting the PVID, which makes it impossible to forward any
incomming untagged frame with vlan_filtering enabled.

Since vid 0 cannot be used for the PVID, we can use vid 0 to indicate
that the PVID is not set, which is slightly more efficient than using
the VLAN_TAG_PRESENT.

Fix the problem by getting rid of using the VLAN_TAG_PRESENT.

Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
---
 net/bridge/br_private.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 598cb0b..435ca4d 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -646,9 +646,7 @@ static inline u16 br_get_pvid(const struct net_port_vlans *v)
 	 * vid wasn't set
 	 */
 	smp_rmb();
-	return (v->pvid & VLAN_TAG_PRESENT) ?
-			(v->pvid & ~VLAN_TAG_PRESENT) :
-			VLAN_N_VID;
+	return v->pvid ?: VLAN_N_VID;
 }
 
 #else
-- 
1.8.1.2

  parent reply	other threads:[~2013-09-10 10:37 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 10:27 [PATCH net 0/4] bridge: Fix problems around the PVID Toshiaki Makita
2013-09-10 10:32 ` [PATCH net 1/4] bridge: Don't use VID 0 and 4095 in vlan filtering Toshiaki Makita
2013-09-10 14:22   ` Vlad Yasevich
2013-09-12 19:55     ` David Miller
2013-09-12 20:57       ` Vlad Yasevich
2013-09-10 10:34 ` [PATCH net 2/4] bridge: Handle priority-tagged frames properly Toshiaki Makita
2013-09-10 14:03   ` Vlad Yasevich
2013-09-11  7:00     ` Toshiaki Makita
2013-09-11 16:32       ` Vlad Yasevich
2013-09-12  8:08         ` Toshiaki Makita
2013-09-10 10:37 ` Toshiaki Makita [this message]
2013-09-10 14:08   ` [PATCH net 3/4] bridge: Fix the way the PVID is referenced Vlad Yasevich
2013-09-10 14:24   ` Vlad Yasevich
2013-09-10 10:39 ` [PATCH net 4/4] bridge: Fix updating FDB entries when the PVID is applied Toshiaki Makita
2013-09-10 14:24   ` Vlad Yasevich
2013-09-12 20:00 ` [PATCH net 0/4] bridge: Fix problems around the PVID David Miller
2013-09-13 12:06   ` Toshiaki Makita
2013-09-13 15:21     ` Veaceslav Falico
2013-09-14 15:42       ` Toshiaki Makita
2013-09-16 17:49     ` Vlad Yasevich
2013-09-17  8:12       ` Toshiaki Makita
2013-09-23 14:41         ` Vlad Yasevich
2013-09-24 11:45           ` Toshiaki Makita
2013-09-24 13:35             ` Vlad Yasevich
2013-09-24 17:30               ` Toshiaki Makita
2013-09-24 17:55                 ` Vlad Yasevich
2013-09-26 10:38                   ` Toshiaki Makita
2013-09-26 14:22                     ` Vlad Yasevich
2013-09-27 17:11                       ` Toshiaki Makita
2013-09-27 18:10                         ` Vlad Yasevich
2013-09-30 11:46                           ` Toshiaki Makita
2013-09-30 16:01                             ` Vlad Yasevich
2013-10-01 11:56                               ` Toshiaki Makita
2013-10-09 15:01                                 ` Vlad Yasevich
2013-10-11  7:34                                   ` Toshiaki Makita
2013-10-11 14:14                                     ` Vlad Yasevich
2013-10-13 16:11                                       ` Toshiaki Makita
2013-10-15 13:55                                         ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378809451.3988.11.camel@ubuntu-vm-makita \
    --to=makita.toshiaki@lab.ntt.co.jp \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox