From: Joe Perches <joe@perches.com>
To: Matt Zanchelli <zanchm@rpi.edu>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument.
Date: Thu, 24 Oct 2013 15:30:52 -0700 [thread overview]
Message-ID: <1382653852.22433.82.camel@joe-AO722> (raw)
In-Reply-To: <1382650645-23973-1-git-send-email-zanchm@rpi.edu>
On Thu, 2013-10-24 at 21:37 +0000, Matt Zanchelli wrote:
> Updated prinkt() statement in mac_sonic_probe() function to match current
> convention of using KERN style leading argument.
s/prinkt/printk/
> diff --git a/drivers/net/ethernet/natsemi/macsonic.c b/drivers/net/ethernet/natsemi/macsonic.c
[]
> @@ -601,7 +601,7 @@ found:
> if (err)
> goto out;
>
> - printk("%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
> + printk(KERN_INFO "%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
It'd be nicer to use:
netdev_info(dev, "MAC %pM IRQ %d\n", dev->dev_addr, dev->irq);
Nicer still to convert all the printks in this
file to netdev_<level> where possible.
prev parent reply other threads:[~2013-10-24 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:37 [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument Matt Zanchelli
2013-10-24 22:30 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382653852.22433.82.camel@joe-AO722 \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=zanchm@rpi.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox