* [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument.
@ 2013-10-24 21:37 Matt Zanchelli
2013-10-24 22:30 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Matt Zanchelli @ 2013-10-24 21:37 UTC (permalink / raw)
To: netdev; +Cc: Matt Zanchelli
Updated prinkt() statement in mac_sonic_probe() function to match current
convention of using KERN style leading argument.
Reviewed-by: Daniel Felizardo <danfelizardo@gmail.com>
Reviewed-by: Nicole Negedly <nnegedly@gmail.com>
Reviewed-by: Maxwell Ensley-Field <mensleyfield@gmail.com>
Signed-off-by: Matt Zanchelli <zanchm@rpi.edu>
---
drivers/net/ethernet/natsemi/macsonic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/natsemi/macsonic.c b/drivers/net/ethernet/natsemi/macsonic.c
index 346a4e0..3eca756 100644
--- a/drivers/net/ethernet/natsemi/macsonic.c
+++ b/drivers/net/ethernet/natsemi/macsonic.c
@@ -601,7 +601,7 @@ found:
if (err)
goto out;
- printk("%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
+ printk(KERN_INFO "%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
return 0;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument.
2013-10-24 21:37 [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument Matt Zanchelli
@ 2013-10-24 22:30 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2013-10-24 22:30 UTC (permalink / raw)
To: Matt Zanchelli; +Cc: netdev
On Thu, 2013-10-24 at 21:37 +0000, Matt Zanchelli wrote:
> Updated prinkt() statement in mac_sonic_probe() function to match current
> convention of using KERN style leading argument.
s/prinkt/printk/
> diff --git a/drivers/net/ethernet/natsemi/macsonic.c b/drivers/net/ethernet/natsemi/macsonic.c
[]
> @@ -601,7 +601,7 @@ found:
> if (err)
> goto out;
>
> - printk("%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
> + printk(KERN_INFO "%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
It'd be nicer to use:
netdev_info(dev, "MAC %pM IRQ %d\n", dev->dev_addr, dev->irq);
Nicer still to convert all the printks in this
file to netdev_<level> where possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-24 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-24 21:37 [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument Matt Zanchelli
2013-10-24 22:30 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox