public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH-next] intel ethernet: fix s390 build failure due to implicit prefetch.h
@ 2014-01-10 19:28 Paul Gortmaker
  2014-01-10 19:52 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Gortmaker @ 2014-01-10 19:28 UTC (permalink / raw)
  To: e1000-devel; +Cc: Sibai Li, Paul Gortmaker, netdev, Jesse Brandeburg

As of commit 7f12ad741a4870b8b6e3aafbcd868d0191770802 ("i40evf: transmit
and receive functionality") the s390 builds (allyesconfig) fail with:

drivers/net/ethernet/intel/i40evf/i40e_txrx.c: In function 'i40e_clean_rx_irq':
drivers/net/ethernet/intel/i40evf/i40e_txrx.c:818:3: error: implicit declaration of function 'prefetch'
make[5]: *** [drivers/net/ethernet/intel/i40evf/i40e_txrx.o] Error 1

due to an implicit assumption that the prototype from linux/prefetch.h
will be present.

Cc: Mitch Williams <mitch.a.williams@intel.com>
Cc: Greg Rose <gregory.v.rose@intel.com>
Cc: Sibai Li <sibai.li@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
index 8f2b3b2..ffdb01d 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
@@ -21,6 +21,8 @@
  *
  ******************************************************************************/
 
+#include <linux/prefetch.h>
+
 #include "i40evf.h"
 
 static inline __le64 build_ctob(u32 td_cmd, u32 td_offset, unsigned int size,
-- 
1.8.5.1


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH-next] intel ethernet: fix s390 build failure due to implicit prefetch.h
  2014-01-10 19:28 [PATCH-next] intel ethernet: fix s390 build failure due to implicit prefetch.h Paul Gortmaker
@ 2014-01-10 19:52 ` David Miller
  2014-01-10 19:56   ` Jeff Kirsher
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-01-10 19:52 UTC (permalink / raw)
  To: paul.gortmaker
  Cc: e1000-devel, netdev, jesse.brandeburg, mitch.a.williams,
	gregory.v.rose, sibai.li, jeffrey.t.kirsher

From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Fri, 10 Jan 2014 14:28:16 -0500

> As of commit 7f12ad741a4870b8b6e3aafbcd868d0191770802 ("i40evf: transmit
> and receive functionality") the s390 builds (allyesconfig) fail with:
> 
> drivers/net/ethernet/intel/i40evf/i40e_txrx.c: In function 'i40e_clean_rx_irq':
> drivers/net/ethernet/intel/i40evf/i40e_txrx.c:818:3: error: implicit declaration of function 'prefetch'
> make[5]: *** [drivers/net/ethernet/intel/i40evf/i40e_txrx.o] Error 1
> 
> due to an implicit assumption that the prototype from linux/prefetch.h
> will be present.
> 
> Cc: Mitch Williams <mitch.a.williams@intel.com>
> Cc: Greg Rose <gregory.v.rose@intel.com>
> Cc: Sibai Li <sibai.li@intel.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I hope the Intel folks will pick this up quickly and push it to me.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH-next] intel ethernet: fix s390 build failure due to implicit prefetch.h
  2014-01-10 19:52 ` David Miller
@ 2014-01-10 19:56   ` Jeff Kirsher
  0 siblings, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2014-01-10 19:56 UTC (permalink / raw)
  To: David Miller
  Cc: sibai.li, e1000-devel, netdev, jesse.brandeburg, paul.gortmaker


[-- Attachment #1.1: Type: text/plain, Size: 1106 bytes --]

On Fri, 2014-01-10 at 14:52 -0500, David Miller wrote:
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date: Fri, 10 Jan 2014 14:28:16 -0500
> 
> > As of commit 7f12ad741a4870b8b6e3aafbcd868d0191770802 ("i40evf: transmit
> > and receive functionality") the s390 builds (allyesconfig) fail with:
> > 
> > drivers/net/ethernet/intel/i40evf/i40e_txrx.c: In function 'i40e_clean_rx_irq':
> > drivers/net/ethernet/intel/i40evf/i40e_txrx.c:818:3: error: implicit declaration of function 'prefetch'
> > make[5]: *** [drivers/net/ethernet/intel/i40evf/i40e_txrx.o] Error 1
> > 
> > due to an implicit assumption that the prototype from linux/prefetch.h
> > will be present.
> > 
> > Cc: Mitch Williams <mitch.a.williams@intel.com>
> > Cc: Greg Rose <gregory.v.rose@intel.com>
> > Cc: Sibai Li <sibai.li@intel.com>
> > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> I hope the Intel folks will pick this up quickly and push it to me.

Yep, Aaron has it in the queue and it is being reviewed and tested
currently.

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 388 bytes --]

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]

_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-10 19:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-10 19:28 [PATCH-next] intel ethernet: fix s390 build failure due to implicit prefetch.h Paul Gortmaker
2014-01-10 19:52 ` David Miller
2014-01-10 19:56   ` Jeff Kirsher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox