* [PATCH] net: fix 'ip rule' iif/oif device rename
@ 2014-02-08 0:23 Maciej Żenczykowski
2014-02-08 1:41 ` Eric Dumazet
2014-02-10 3:03 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Maciej Żenczykowski @ 2014-02-08 0:23 UTC (permalink / raw)
To: Maciej Żenczykowski, David S. Miller
Cc: netdev, Willem de Bruijn, Eric Dumazet, Chris Davis,
Carlo Contavalli
From: Maciej Żenczykowski <maze@google.com>
ip rules with iif/oif references do not update:
(detach/attach) across interface renames.
Signed-off-by: Maciej Żenczykowski <maze@google.com>
CC: Willem de Bruijn <willemb@google.com>
CC: Eric Dumazet <edumazet@google.com>
CC: Chris Davis <chrismd@google.com>
CC: Carlo Contavalli <ccontavalli@google.com>
Google-Bug-Id: 12936021
---
net/core/fib_rules.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index f409e0bd35c0..185c341fafbd 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -745,6 +745,13 @@ static int fib_rules_event(struct notifier_block *this, unsigned long event,
attach_rules(&ops->rules_list, dev);
break;
+ case NETDEV_CHANGENAME:
+ list_for_each_entry(ops, &net->rules_ops, list) {
+ detach_rules(&ops->rules_list, dev);
+ attach_rules(&ops->rules_list, dev);
+ }
+ break;
+
case NETDEV_UNREGISTER:
list_for_each_entry(ops, &net->rules_ops, list)
detach_rules(&ops->rules_list, dev);
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: fix 'ip rule' iif/oif device rename
2014-02-08 0:23 [PATCH] net: fix 'ip rule' iif/oif device rename Maciej Żenczykowski
@ 2014-02-08 1:41 ` Eric Dumazet
2014-02-10 3:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2014-02-08 1:41 UTC (permalink / raw)
To: Maciej Żenczykowski
Cc: Maciej Żenczykowski, David S. Miller, netdev,
Willem de Bruijn, Eric Dumazet, Chris Davis, Carlo Contavalli
On Fri, 2014-02-07 at 16:23 -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> ip rules with iif/oif references do not update:
> (detach/attach) across interface renames.
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> CC: Willem de Bruijn <willemb@google.com>
> CC: Eric Dumazet <edumazet@google.com>
> CC: Chris Davis <chrismd@google.com>
> CC: Carlo Contavalli <ccontavalli@google.com>
>
> Google-Bug-Id: 12936021
> ---
> net/core/fib_rules.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fix 'ip rule' iif/oif device rename
2014-02-08 0:23 [PATCH] net: fix 'ip rule' iif/oif device rename Maciej Żenczykowski
2014-02-08 1:41 ` Eric Dumazet
@ 2014-02-10 3:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-02-10 3:03 UTC (permalink / raw)
To: zenczykowski; +Cc: maze, netdev, willemb, edumazet, chrismd, ccontavalli
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Fri, 7 Feb 2014 16:23:48 -0800
> From: Maciej Żenczykowski <maze@google.com>
>
> ip rules with iif/oif references do not update:
> (detach/attach) across interface renames.
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> CC: Willem de Bruijn <willemb@google.com>
> CC: Eric Dumazet <edumazet@google.com>
> CC: Chris Davis <chrismd@google.com>
> CC: Carlo Contavalli <ccontavalli@google.com>
>
> Google-Bug-Id: 12936021
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-10 3:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 0:23 [PATCH] net: fix 'ip rule' iif/oif device rename Maciej Żenczykowski
2014-02-08 1:41 ` Eric Dumazet
2014-02-10 3:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox