Netdev List
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Aaron Conole <aconole@redhat.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	dev@openvswitch.org
Subject: Re: [PATCH net 2/7] selftests: openvswitch: add config file
Date: Fri, 17 Jul 2026 11:39:40 +0200	[thread overview]
Message-ID: <13a0db90-d498-4d1d-845d-f3fc0d5437b2@kernel.org> (raw)
In-Reply-To: <454FC9EC-8F3C-4999-BE7B-91EADC392EF7@redhat.com>

Hi Eelco,

Thank you for the review!

On 16/07/2026 10:15, Eelco Chaudron wrote:
> On 10 Jul 2026, at 20:04, Matthieu Baerts (NGI0) wrote:
> 
>> The kselftests doc mentions that a config file should be present "if a
>> test needs specific kernel config options enabled". This selftest
>> requires some kernel config, but no config file was provided.
>>
>> We could say that a sub-target could use the parent's config file, but
>> the kselftests doc doesn't mention anything about that. Plus the
>> net/openvswitch target is the only net target without a config file.
>>
>> Here is a new config file, which is a trimmed version of the net one,
>> with hopefully the minimal required kconfig on top of 'make defconfig'.
>>
>> The Fixes tag points to the introduction of the net/openvswitch target,
>> just to help validating this target on stable kernels.
>>
>> Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> Thanks for adding this Matthieu.
> 
> The changes look good to me, and I've tested the configuration and
> it works fine. Note that the config cannot be used for the OVS
> make-kernel test as it's missing some modules. But that's fine for
> the purpose of this kselftest suite.
> 
> Do note that when adding new tests to the openvswitch kselftest
> suite, they should be validated against this config, as the upstream
> CI uses the net config, which has more modules enabled.

Indeed. I'm currently doing some modifications for this CI, and this
behaviour might change in the future to use new config file for this
net/openvswitch target.

Cheers,
Matt

  reply	other threads:[~2026-07-20 10:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 18:04 [PATCH net 0/7] selftests: net: add missing kconfig and settings Matthieu Baerts (NGI0)
2026-07-10 18:04 ` [PATCH net 1/7] selftests: af_unix: add USER_NS config Matthieu Baerts (NGI0)
2026-07-10 18:51   ` Kuniyuki Iwashima
2026-07-10 18:04 ` [PATCH net 2/7] selftests: openvswitch: add config file Matthieu Baerts (NGI0)
2026-07-16  8:15   ` Eelco Chaudron
2026-07-17  9:39     ` Matthieu Baerts [this message]
2026-07-16 15:38   ` Aaron Conole
2026-07-16 20:00     ` Aaron Conole
2026-07-17  9:39       ` Matthieu Baerts
2026-07-20 14:43         ` Aaron Conole
2026-07-20 15:24           ` Matthieu Baerts
2026-07-10 18:04 ` [PATCH net 3/7] selftests: ovpn: add IPV6 and VETH configs Matthieu Baerts (NGI0)
2026-07-13 11:42   ` Antonio Quartulli
2026-07-10 18:04 ` [PATCH net 4/7] selftests: ovpn: increase timeout Matthieu Baerts (NGI0)
2026-07-13 11:44   ` Antonio Quartulli
2026-07-10 18:04 ` [PATCH net 5/7] selftests: drv-net: " Matthieu Baerts (NGI0)
2026-07-10 18:04 ` [PATCH net 6/7] selftests: drv-net: add missing kconfig for psp.py Matthieu Baerts (NGI0)
2026-07-10 21:26   ` Wei Wang
2026-07-10 18:04 ` [PATCH net 7/7] selftests: netconsole: ignore busywait errors Matthieu Baerts (NGI0)
2026-07-13 10:41   ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13a0db90-d498-4d1d-845d-f3fc0d5437b2@kernel.org \
    --to=matttbe@kernel.org \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox