From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, f.fainelli@gmail.com,
jonas.gorski@gmail.com, andrew@lunn.ch, olteanv@gmail.com,
hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: net: move bcm6368-mdio-mux bindings to b53
Date: Sun, 19 Mar 2023 12:35:29 +0100 [thread overview]
Message-ID: <13e49e62-6e01-b736-e0c4-379a82299ddb@linaro.org> (raw)
In-Reply-To: <20230317113427.302162-2-noltari@gmail.com>
On 17/03/2023 12:34, Álvaro Fernández Rojas wrote:
> b53 MMAP devices have a MDIO Mux bus controller that must be registered after
> properly initializing the switch. If the MDIO Mux controller is registered
> from a separate driver and the device has an external switch present, it will
> cause a race condition which will hang the device.
Are you sure it is wrapped according to Linux coding style?
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
Your rationale does not justify incompatible binding change, especially
that it could be probably solved by including the child in the parent.
Anyway, Linux driver boot order is not a reason to change bindings really.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-19 11:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 11:34 [PATCH 0/3] net: dsa: b53: mmap: add MDIO Mux bus controller Álvaro Fernández Rojas
2023-03-17 11:34 ` [PATCH 1/3] dt-bindings: net: move bcm6368-mdio-mux bindings to b53 Álvaro Fernández Rojas
2023-03-19 11:35 ` Krzysztof Kozlowski [this message]
2023-03-17 11:34 ` [PATCH 2/3] net: dsa: b53: mmap: register MDIO Mux bus controller Álvaro Fernández Rojas
2023-03-17 11:51 ` Vladimir Oltean
2023-03-17 12:06 ` Álvaro Fernández Rojas
2023-03-17 13:04 ` Vladimir Oltean
2023-03-17 14:17 ` Álvaro Fernández Rojas
2023-03-17 14:29 ` Vladimir Oltean
2023-03-17 16:23 ` Álvaro Fernández Rojas
2023-03-17 16:41 ` Florian Fainelli
2023-03-17 16:44 ` Álvaro Fernández Rojas
2023-03-19 9:45 ` Álvaro Fernández Rojas
2023-03-20 10:27 ` Jonas Gorski
2023-03-20 15:21 ` Álvaro Fernández Rojas
2023-03-17 16:26 ` Andrew Lunn
2023-03-17 16:30 ` Álvaro Fernández Rojas
2023-03-17 16:37 ` Andrew Lunn
2023-03-17 11:34 ` [PATCH 3/3] net: mdio: remove BCM6368 MDIO mux bus driver Álvaro Fernández Rojas
2023-03-19 11:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13e49e62-6e01-b736-e0c4-379a82299ddb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox