Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, f.fainelli@gmail.com,
	jonas.gorski@gmail.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] net: dsa: b53: mmap: register MDIO Mux bus controller
Date: Fri, 17 Mar 2023 17:26:56 +0100	[thread overview]
Message-ID: <1ed6d7d9-4d3e-4bcb-8023-75bb52c2f272@lunn.ch> (raw)
In-Reply-To: <CAKR-sGeFZLnuqH=4Gok1URJEvrQKxbk203Q8zdMd9830G_XD7A@mail.gmail.com>

> > The proposed solution is too radical for a problem that was not properly
> > characterized yet, so this patch set has my temporary NACK.
> 
> Forgive me, but why do you consider this solution too radical?

I have to agree with Vladimir here. The problem is not the driver, but
when the driver is instantiated. It seems radical to remove a driver
just because it loads at the wrong time. Ideally you want the driver
to figure out now is not a good time and return -EPROBE_DEFER, because
a resource it requires it not available.

  Andrew

  parent reply	other threads:[~2023-03-17 16:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 11:34 [PATCH 0/3] net: dsa: b53: mmap: add MDIO Mux bus controller Álvaro Fernández Rojas
2023-03-17 11:34 ` [PATCH 1/3] dt-bindings: net: move bcm6368-mdio-mux bindings to b53 Álvaro Fernández Rojas
2023-03-19 11:35   ` Krzysztof Kozlowski
2023-03-17 11:34 ` [PATCH 2/3] net: dsa: b53: mmap: register MDIO Mux bus controller Álvaro Fernández Rojas
2023-03-17 11:51   ` Vladimir Oltean
2023-03-17 12:06     ` Álvaro Fernández Rojas
2023-03-17 13:04       ` Vladimir Oltean
2023-03-17 14:17         ` Álvaro Fernández Rojas
2023-03-17 14:29           ` Vladimir Oltean
2023-03-17 16:23             ` Álvaro Fernández Rojas
2023-03-17 16:41               ` Florian Fainelli
2023-03-17 16:44                 ` Álvaro Fernández Rojas
2023-03-19  9:45                 ` Álvaro Fernández Rojas
2023-03-20 10:27                   ` Jonas Gorski
2023-03-20 15:21                     ` Álvaro Fernández Rojas
2023-03-17 16:26           ` Andrew Lunn [this message]
2023-03-17 16:30             ` Álvaro Fernández Rojas
2023-03-17 16:37               ` Andrew Lunn
2023-03-17 11:34 ` [PATCH 3/3] net: mdio: remove BCM6368 MDIO mux bus driver Álvaro Fernández Rojas
2023-03-19 11:36   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ed6d7d9-4d3e-4bcb-8023-75bb52c2f272@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox