Netdev List
 help / color / mirror / Atom feed
* Added Sign-off [PATCH] ip netns: Show error message if mkdir failed to create /var/run/netns
@ 2014-08-28 13:56 vadimk
  0 siblings, 0 replies; only message in thread
From: vadimk @ 2014-08-28 13:56 UTC (permalink / raw)
  To: netdev; +Cc: vadimk

Currently if mkdir failed with "Permission denied" error then "mount --make-shared ..."
error message will be showed because /var/run/netns does not exist.

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 ip/ipnetns.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/ip/ipnetns.c b/ip/ipnetns.c
index 633b5b9..7f82908 100644
--- a/ip/ipnetns.c
+++ b/ip/ipnetns.c
@@ -407,7 +407,13 @@ static int netns_add(int argc, char **argv)
 	snprintf(netns_path, sizeof(netns_path), "%s/%s", NETNS_RUN_DIR, name);
 
 	/* Create the base netns directory if it doesn't exist */
-	mkdir(NETNS_RUN_DIR, S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH);
+	if (mkdir(NETNS_RUN_DIR, S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH)) {
+		if (errno != EEXIST) {
+			fprintf(stderr, "mkdir %s failed: %s\n",
+				NETNS_RUN_DIR, strerror(errno));
+			return -1;
+		}
+	}
 
 	/* Make it possible for network namespace mounts to propagate between
 	 * mount namespaces.  This makes it likely that a unmounting a network
-- 
2.0.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-08-28 14:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-28 13:56 Added Sign-off [PATCH] ip netns: Show error message if mkdir failed to create /var/run/netns vadimk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox