* [PATCH net-next] cxgb4: Fix static checker warning
@ 2014-11-12 9:31 Hariprasad Shenai
2014-11-12 20:05 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Hariprasad Shenai @ 2014-11-12 9:31 UTC (permalink / raw)
To: netdev; +Cc: davem, leedom, anish, nirranjan, kumaras, Hariprasad Shenai
Fix static checker warning that got introduced in commit e2ac9628959cc152
("cxgb4: Cleanup macros so they follow the same style and look consistent, part
2") due to accidental checkin of bogus line.
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index d13d36a..660bf0f 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -5752,7 +5752,6 @@ static int adap_init0(struct adapter *adap)
"No Configuration File present "
"on adapter. Using hard-wired "
"configuration parameters.\n");
- goto bye;
ret = adap_init0_no_config(adap, reset);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH net-next] cxgb4: Fix static checker warning
@ 2015-06-05 9:06 Hariprasad Shenai
2015-06-06 4:32 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Hariprasad Shenai @ 2015-06-05 9:06 UTC (permalink / raw)
To: netdev; +Cc: davem, leedom, nirranjan, Hariprasad Shenai
The patch e85c9a7abfa4: ("cxgb4/cxgb4vf: Add code to calculate T5 BAR2
Offsets for SGE Queue Registers") from Dec 3, 2014, leads to the
following static checker warning:
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:5358
t4_bar2_sge_qregs()
warn: should '(qid >> qpp_shift) << page_shift' be a 64 bit type?
This patch fixes it
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
---
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index b411098..fdda0f8 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -6053,7 +6053,7 @@ int t4_bar2_sge_qregs(struct adapter *adapter,
* o The BAR2 Queue ID.
* o The BAR2 Queue ID Offset into the BAR2 page.
*/
- bar2_page_offset = ((qid >> qpp_shift) << page_shift);
+ bar2_page_offset = ((u64)(qid >> qpp_shift) << page_shift);
bar2_qid = qid & qpp_mask;
bar2_qid_offset = bar2_qid * SGE_UDB_SIZE;
--
2.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] cxgb4: Fix static checker warning
2015-06-05 9:06 Hariprasad Shenai
@ 2015-06-06 4:32 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-06-06 4:32 UTC (permalink / raw)
To: hariprasad; +Cc: netdev, leedom, nirranjan
From: Hariprasad Shenai <hariprasad@chelsio.com>
Date: Fri, 5 Jun 2015 14:36:33 +0530
> The patch e85c9a7abfa4: ("cxgb4/cxgb4vf: Add code to calculate T5 BAR2
> Offsets for SGE Queue Registers") from Dec 3, 2014, leads to the
> following static checker warning:
>
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:5358
> t4_bar2_sge_qregs()
> warn: should '(qid >> qpp_shift) << page_shift' be a 64 bit type?
>
> This patch fixes it
>
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-06 4:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 9:31 [PATCH net-next] cxgb4: Fix static checker warning Hariprasad Shenai
2014-11-12 20:05 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-06-05 9:06 Hariprasad Shenai
2015-06-06 4:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox