* [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h
@ 2014-11-17 21:08 Fabian Frederick
2014-11-17 21:22 ` Eric Dumazet
2014-11-18 20:55 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Fabian Frederick @ 2014-11-17 21:08 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, David S. Miller, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
net/core/link_watch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/link_watch.c b/net/core/link_watch.c
index bd0767e..49a9e3e 100644
--- a/net/core/link_watch.c
+++ b/net/core/link_watch.c
@@ -21,7 +21,7 @@
#include <linux/spinlock.h>
#include <linux/workqueue.h>
#include <linux/bitops.h>
-#include <asm/types.h>
+#include <linux/types.h>
enum lw_bits {
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h
2014-11-17 21:08 [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h Fabian Frederick
@ 2014-11-17 21:22 ` Eric Dumazet
2014-11-17 21:35 ` David Miller
2014-11-18 20:55 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2014-11-17 21:22 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, David S. Miller, netdev
On Mon, 2014-11-17 at 22:08 +0100, Fabian Frederick wrote:
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> net/core/link_watch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
> index bd0767e..49a9e3e 100644
> --- a/net/core/link_watch.c
> +++ b/net/core/link_watch.c
> @@ -21,7 +21,7 @@
> #include <linux/spinlock.h>
> #include <linux/workqueue.h>
> #include <linux/bitops.h>
> -#include <asm/types.h>
> +#include <linux/types.h>
>
We have 99 such occurrences in net/
Are you going to send 99 patches ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h
2014-11-17 21:22 ` Eric Dumazet
@ 2014-11-17 21:35 ` David Miller
2014-11-17 22:05 ` Eric Dumazet
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-11-17 21:35 UTC (permalink / raw)
To: eric.dumazet; +Cc: fabf, linux-kernel, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 17 Nov 2014 13:22:56 -0800
> On Mon, 2014-11-17 at 22:08 +0100, Fabian Frederick wrote:
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>> ---
>> net/core/link_watch.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
>> index bd0767e..49a9e3e 100644
>> --- a/net/core/link_watch.c
>> +++ b/net/core/link_watch.c
>> @@ -21,7 +21,7 @@
>> #include <linux/spinlock.h>
>> #include <linux/workqueue.h>
>> #include <linux/bitops.h>
>> -#include <asm/types.h>
>> +#include <linux/types.h>
>>
>
> We have 99 such occurrences in net/
>
> Are you going to send 99 patches ?
Yeah, probably best to consolidate into one or a few patches.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h
2014-11-17 21:35 ` David Miller
@ 2014-11-17 22:05 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2014-11-17 22:05 UTC (permalink / raw)
To: David Miller; +Cc: fabf, linux-kernel, netdev
On Mon, 2014-11-17 at 16:35 -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 17 Nov 2014 13:22:56 -0800
>
> > On Mon, 2014-11-17 at 22:08 +0100, Fabian Frederick wrote:
> >> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> >> ---
> >> net/core/link_watch.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
> >> index bd0767e..49a9e3e 100644
> >> --- a/net/core/link_watch.c
> >> +++ b/net/core/link_watch.c
> >> @@ -21,7 +21,7 @@
> >> #include <linux/spinlock.h>
> >> #include <linux/workqueue.h>
> >> #include <linux/bitops.h>
> >> -#include <asm/types.h>
> >> +#include <linux/types.h>
> >>
> >
> > We have 99 such occurrences in net/
> >
> > Are you going to send 99 patches ?
>
> Yeah, probably best to consolidate into one or a few patches.
BTW the 99 occurrences are for asm/uaccess.h, it seems I gave the reply
on the wrong patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h
2014-11-17 21:08 [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h Fabian Frederick
2014-11-17 21:22 ` Eric Dumazet
@ 2014-11-18 20:55 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2014-11-18 20:55 UTC (permalink / raw)
To: fabf; +Cc: linux-kernel, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Mon, 17 Nov 2014 22:08:22 +0100
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-18 20:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 21:08 [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h Fabian Frederick
2014-11-17 21:22 ` Eric Dumazet
2014-11-17 21:35 ` David Miller
2014-11-17 22:05 ` Eric Dumazet
2014-11-18 20:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox