* [PATCH iproute2 REGRESSION v2] ss: Dont show netlink and packet sockets by default
@ 2014-12-14 17:23 Vadim Kochan
0 siblings, 0 replies; only message in thread
From: Vadim Kochan @ 2014-12-14 17:23 UTC (permalink / raw)
To: netdev; +Cc: Vadim Kochan
From: Vadim Kochan <vadim4j@gmail.com>
Checking by SS_CLOSE state was remowed in:
(45a4770bc0) ss: Remove checking SS_CLOSE state for packet and netlink
which is not really correct because now by default all sockets are seen
when do 'ss'.
Here is most correct fix which considers specified family.
To see netlink sockets:
ss -A netlink
To see packet sockets:
ss -A packet
And ss by default will show only connected/established sockets as it
was before all the time.
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
misc/ss.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/misc/ss.c b/misc/ss.c
index e9927a5..8f39eb8 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -2801,6 +2801,9 @@ static int packet_show(struct filter *f)
int ino;
unsigned long long sk;
+ if (preferred_family != AF_PACKET && !(f->states & (1 << SS_CLOSE)))
+ return 0;
+
if (packet_show_netlink(f, NULL) == 0)
return 0;
@@ -3028,6 +3031,9 @@ static int netlink_show(struct filter *f)
int rq, wq, rc;
unsigned long long sk, cb;
+ if (preferred_family != AF_NETLINK && !(f->states & (1 << SS_CLOSE)))
+ return 0;
+
if (!getenv("PROC_NET_NETLINK") && !getenv("PROC_ROOT") &&
netlink_show_netlink(f, NULL) == 0)
return 0;
--
2.1.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-12-14 17:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-14 17:23 [PATCH iproute2 REGRESSION v2] ss: Dont show netlink and packet sockets by default Vadim Kochan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox