From: Ben Hutchings <ben@decadent.org.uk>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: bwh@kernel.org, netdev@vger.kernel.org
Subject: Re: [ethtool PATCH 1/1] bug fix: SFP Tx BIAS uses memory wrong offset
Date: Sun, 14 Dec 2014 17:48:54 +0000 [thread overview]
Message-ID: <1418579334.3599.132.camel@decadent.org.uk> (raw)
In-Reply-To: <1413367740-11118-1-git-send-email-jhs@emojatatu.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Wed, 2014-10-15 at 06:09 -0400, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> SFF-8472 rev 12.0 indicates the SFP BIAS is at offset 100 of page A2
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied, thanks.
Ben.
> ---
> sfpdiag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sfpdiag.c b/sfpdiag.c
> index 812a2fa..a3dbc9b 100644
> --- a/sfpdiag.c
> +++ b/sfpdiag.c
> @@ -48,7 +48,7 @@
> #define SFF_A2_VCC_HWARN 12
> #define SFF_A2_VCC_LWARN 14
>
> -#define SFF_A2_BIAS 96
> +#define SFF_A2_BIAS 100
> #define SFF_A2_BIAS_HALRM 16
> #define SFF_A2_BIAS_LALRM 18
> #define SFF_A2_BIAS_HWARN 20
--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2014-12-14 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 10:09 [ethtool PATCH 1/1] bug fix: SFP Tx BIAS uses memory wrong offset Jamal Hadi Salim
2014-12-14 17:48 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418579334.3599.132.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=bwh@kernel.org \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox