* [ethtool PATCH 1/1] bug fix: SFP Tx BIAS uses memory wrong offset
@ 2014-10-15 10:09 Jamal Hadi Salim
2014-12-14 17:48 ` Ben Hutchings
0 siblings, 1 reply; 2+ messages in thread
From: Jamal Hadi Salim @ 2014-10-15 10:09 UTC (permalink / raw)
To: bwh; +Cc: netdev, Jamal Hadi Salim
From: Jamal Hadi Salim <jhs@mojatatu.com>
SFF-8472 rev 12.0 indicates the SFP BIAS is at offset 100 of page A2
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
sfpdiag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sfpdiag.c b/sfpdiag.c
index 812a2fa..a3dbc9b 100644
--- a/sfpdiag.c
+++ b/sfpdiag.c
@@ -48,7 +48,7 @@
#define SFF_A2_VCC_HWARN 12
#define SFF_A2_VCC_LWARN 14
-#define SFF_A2_BIAS 96
+#define SFF_A2_BIAS 100
#define SFF_A2_BIAS_HALRM 16
#define SFF_A2_BIAS_LALRM 18
#define SFF_A2_BIAS_HWARN 20
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ethtool PATCH 1/1] bug fix: SFP Tx BIAS uses memory wrong offset
2014-10-15 10:09 [ethtool PATCH 1/1] bug fix: SFP Tx BIAS uses memory wrong offset Jamal Hadi Salim
@ 2014-12-14 17:48 ` Ben Hutchings
0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2014-12-14 17:48 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: bwh, netdev
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Wed, 2014-10-15 at 06:09 -0400, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> SFF-8472 rev 12.0 indicates the SFP BIAS is at offset 100 of page A2
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied, thanks.
Ben.
> ---
> sfpdiag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sfpdiag.c b/sfpdiag.c
> index 812a2fa..a3dbc9b 100644
> --- a/sfpdiag.c
> +++ b/sfpdiag.c
> @@ -48,7 +48,7 @@
> #define SFF_A2_VCC_HWARN 12
> #define SFF_A2_VCC_LWARN 14
>
> -#define SFF_A2_BIAS 96
> +#define SFF_A2_BIAS 100
> #define SFF_A2_BIAS_HALRM 16
> #define SFF_A2_BIAS_LALRM 18
> #define SFF_A2_BIAS_HWARN 20
--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-14 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-15 10:09 [ethtool PATCH 1/1] bug fix: SFP Tx BIAS uses memory wrong offset Jamal Hadi Salim
2014-12-14 17:48 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox