* [PATCH 1/6] virtio/9p: verify device has config space [not found] <1421160167-18498-1-git-send-email-mst@redhat.com> @ 2015-01-13 14:43 ` Michael S. Tsirkin 2015-01-13 14:43 ` [PATCH 4/6] virtio/net: " Michael S. Tsirkin 1 sibling, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2015-01-13 14:43 UTC (permalink / raw) To: linux-kernel Cc: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov, David S. Miller, v9fs-developer, netdev Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/9p needs config space access so make it fail gracefully if not there. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- net/9p/trans_virtio.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index daa749c..d8e376a 100644 --- a/net/9p/trans_virtio.c +++ b/net/9p/trans_virtio.c @@ -524,6 +524,12 @@ static int p9_virtio_probe(struct virtio_device *vdev) int err; struct virtio_chan *chan; + if (!vdev->config->get) { + dev_err(&vdev->dev, "%s failure: config access disabled\n", + __func__); + return -EINVAL; + } + chan = kmalloc(sizeof(struct virtio_chan), GFP_KERNEL); if (!chan) { pr_err("Failed to allocate virtio 9P channel\n"); -- MST ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 4/6] virtio/net: verify device has config space [not found] <1421160167-18498-1-git-send-email-mst@redhat.com> 2015-01-13 14:43 ` [PATCH 1/6] virtio/9p: verify device has config space Michael S. Tsirkin @ 2015-01-13 14:43 ` Michael S. Tsirkin 1 sibling, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2015-01-13 14:43 UTC (permalink / raw) To: linux-kernel; +Cc: netdev, virtualization Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/net needs config space access so make it fail gracefully if not there. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 5ca9771..9bc1072 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1713,6 +1713,12 @@ static int virtnet_probe(struct virtio_device *vdev) struct virtnet_info *vi; u16 max_queue_pairs; + if (!vdev->config->get) { + dev_err(&vdev->dev, "%s failure: config access disabled\n", + __func__); + return -EINVAL; + } + if (!virtnet_validate_features(vdev)) return -EINVAL; -- MST ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 14:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1421160167-18498-1-git-send-email-mst@redhat.com>
2015-01-13 14:43 ` [PATCH 1/6] virtio/9p: verify device has config space Michael S. Tsirkin
2015-01-13 14:43 ` [PATCH 4/6] virtio/net: " Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox