* [PATCH net-next] openvswitch: Fix key serialization.
@ 2015-02-12 17:58 Pravin B Shelar
2015-02-12 19:02 ` Joe Stringer
2015-02-15 4:21 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Pravin B Shelar @ 2015-02-12 17:58 UTC (permalink / raw)
To: davem; +Cc: netdev, joestringer, Pravin B Shelar
Fix typo where mask is used rather than key.
Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
Reported-by: Joe Stringer <joestringer@nicira.com>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
---
net/openvswitch/flow_netlink.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index 993281e..254e466 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -1516,7 +1516,7 @@ int ovs_nla_put_identifier(const struct sw_flow *flow, struct sk_buff *skb)
/* Called with ovs_mutex or RCU read lock. */
int ovs_nla_put_masked_key(const struct sw_flow *flow, struct sk_buff *skb)
{
- return ovs_nla_put_key(&flow->mask->key, &flow->key,
+ return ovs_nla_put_key(&flow->key, &flow->key,
OVS_FLOW_ATTR_KEY, false, skb);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] openvswitch: Fix key serialization.
2015-02-12 17:58 [PATCH net-next] openvswitch: Fix key serialization Pravin B Shelar
@ 2015-02-12 19:02 ` Joe Stringer
2015-02-12 20:41 ` Pravin Shelar
2015-02-15 4:21 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Joe Stringer @ 2015-02-12 19:02 UTC (permalink / raw)
To: Pravin B Shelar; +Cc: David Miller, Linux Netdev List
On 12 February 2015 at 09:58, Pravin B Shelar <pshelar@nicira.com> wrote:
> Fix typo where mask is used rather than key.
>
> Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
> Reported-by: Joe Stringer <joestringer@nicira.com>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
> ---
Thanks for looking into this. So in general we zero-initialize the
key, but not the mask---then use the key to determine which parts of
the key (or mask) to serialize?
This fixes the problem I was seeing.
Acked-by: Joe Stringer <joestringer@nicira.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] openvswitch: Fix key serialization.
2015-02-12 19:02 ` Joe Stringer
@ 2015-02-12 20:41 ` Pravin Shelar
0 siblings, 0 replies; 4+ messages in thread
From: Pravin Shelar @ 2015-02-12 20:41 UTC (permalink / raw)
To: Joe Stringer; +Cc: David Miller, Linux Netdev List
On Thu, Feb 12, 2015 at 11:02 AM, Joe Stringer <joestringer@nicira.com> wrote:
> On 12 February 2015 at 09:58, Pravin B Shelar <pshelar@nicira.com> wrote:
>> Fix typo where mask is used rather than key.
>>
>> Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
>> Reported-by: Joe Stringer <joestringer@nicira.com>
>> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
>> ---
>
> Thanks for looking into this. So in general we zero-initialize the
> key, but not the mask---then use the key to determine which parts of
> the key (or mask) to serialize?
>
Mask is also initialized in ovs_match_init().
> This fixes the problem I was seeing.
>
> Acked-by: Joe Stringer <joestringer@nicira.com>
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] openvswitch: Fix key serialization.
2015-02-12 17:58 [PATCH net-next] openvswitch: Fix key serialization Pravin B Shelar
2015-02-12 19:02 ` Joe Stringer
@ 2015-02-15 4:21 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-02-15 4:21 UTC (permalink / raw)
To: pshelar; +Cc: netdev, joestringer
From: Pravin B Shelar <pshelar@nicira.com>
Date: Thu, 12 Feb 2015 09:58:48 -0800
> Fix typo where mask is used rather than key.
>
> Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
> Reported-by: Joe Stringer <joestringer@nicira.com>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-15 4:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-12 17:58 [PATCH net-next] openvswitch: Fix key serialization Pravin B Shelar
2015-02-12 19:02 ` Joe Stringer
2015-02-12 20:41 ` Pravin Shelar
2015-02-15 4:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox