* [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write()
@ 2015-02-20 22:24 Alexey Khoroshilov
2015-02-20 23:28 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2015-02-20 22:24 UTC (permalink / raw)
To: Jeff Kirsher
Cc: Alexey Khoroshilov, Linux NICS, e1000-devel, netdev, linux-kernel,
ldv-project
The patch fixes a leak of 'cmd_buf' when copy_from_user() failed
in i40e_dbg_command_write().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 61236f983971..c17ee77100d3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -989,8 +989,10 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
if (!cmd_buf)
return count;
bytes_not_copied = copy_from_user(cmd_buf, buffer, count);
- if (bytes_not_copied < 0)
+ if (bytes_not_copied < 0) {
+ kfree(cmd_buf);
return bytes_not_copied;
+ }
if (bytes_not_copied > 0)
count -= bytes_not_copied;
cmd_buf[count] = '\0';
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write()
2015-02-20 22:24 [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write() Alexey Khoroshilov
@ 2015-02-20 23:28 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2015-02-20 23:28 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: Linux NICS, e1000-devel, netdev, linux-kernel, ldv-project
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Sat, 2015-02-21 at 01:24 +0300, Alexey Khoroshilov wrote:
> The patch fixes a leak of 'cmd_buf' when copy_from_user() failed
> in i40e_dbg_command_write().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks Alexey, I have added your patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-20 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 22:24 [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write() Alexey Khoroshilov
2015-02-20 23:28 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox