Re: [net-next PATCH 1/2] igb: Fix warning ‘pin’ may be used uninitialized

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Thu, 2015-03-05 at 11:24 -0800, Alexander Duyck wrote:
> When building the kernel using the gcc 4.8.3 compiler included in
> Fedora 20
> I was repeatedly seeing the warning:
> 
>  drivers/net/ethernet/intel/igb/igb_ptp.c: In function
> ‘igb_ptp_feature_enable_i210’:
>  drivers/net/ethernet/intel/igb/igb_ptp.c:395:21: warning: ‘pin’ may
> be used uninitialized in this function
>  [-Wmaybe-uninitialized]
>    tssdp &= ~ts_sdp_en[pin];
>                      ^
>  drivers/net/ethernet/intel/igb/igb_ptp.c:471:6: note: ‘pin’ was
> declared here
>    int pin;
>        ^
> 
> To resolve it I am assigning the pin a value of -1 when it is
> instantiated.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Alex, I have added your patch to my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]