Re: [net-next PATCH 2/2] igb: Make arrays on stack static const to avoid reallocation

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Thu, 2015-03-05 at 11:25 -0800, Alexander Duyck wrote:
> While addressing the pin problem I noticed that all of the pin
> register
> values where having to be pushed onto the stack each time the function
> was
> called.  To avoid that I am making them static const so that they
> should
> only need to be allocated once and we can avoid all the instructions
> to get
> them onto the stack..
> 
> size before:
>    text    data     bss     dec     hex filename
>  161477   10512       8  171997
> 29fdd drivers/net/ethernet/intel/igb/igb.ko
> 
> size after:
>    text    data     bss     dec     hex filename
>  161205   10512       8  171725
> 29ecd drivers/net/ethernet/intel/igb/igb.ko
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c |   24
> ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Thanks Alex, I have added your patch to my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]