* [PATCH net-next] net: rocker: Use ether_addr_equal
@ 2015-04-30 6:21 Simon Horman
2015-05-01 5:05 ` Scott Feldman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Simon Horman @ 2015-04-30 6:21 UTC (permalink / raw)
To: Jiri Pirko, Scott Feldman, David Miller; +Cc: netdev, Simon Horman
A small cleanup to make use of the ether_addr_equal helper.
Signed-off-by: Simon Horman <simon.horman@netronome.com>
---
Compile tested only
---
drivers/net/ethernet/rocker/rocker.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
index a570a60533be..062ba168d893 100644
--- a/drivers/net/ethernet/rocker/rocker.c
+++ b/drivers/net/ethernet/rocker/rocker.c
@@ -2500,7 +2500,7 @@ static int rocker_flow_tbl_bridge(struct rocker_port *rocker_port,
if (eth_dst_mask) {
entry->key.bridge.has_eth_dst_mask = 1;
ether_addr_copy(entry->key.bridge.eth_dst_mask, eth_dst_mask);
- if (memcmp(eth_dst_mask, ff_mac, ETH_ALEN))
+ if (!ether_addr_equal(eth_dst_mask, ff_mac))
wild = true;
}
@@ -2573,7 +2573,7 @@ static int rocker_flow_tbl_acl(struct rocker_port *rocker_port,
priority = ROCKER_PRIORITY_ACL_NORMAL;
if (eth_dst && eth_dst_mask) {
- if (memcmp(eth_dst_mask, mcast_mac, ETH_ALEN) == 0)
+ if (ether_addr_equal(eth_dst_mask, mcast_mac))
priority = ROCKER_PRIORITY_ACL_DFLT;
else if (is_link_local_ether_addr(eth_dst))
priority = ROCKER_PRIORITY_ACL_CTRL;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: rocker: Use ether_addr_equal
2015-04-30 6:21 [PATCH net-next] net: rocker: Use ether_addr_equal Simon Horman
@ 2015-05-01 5:05 ` Scott Feldman
2015-05-01 7:27 ` Jiri Pirko
2015-05-02 1:48 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Scott Feldman @ 2015-05-01 5:05 UTC (permalink / raw)
To: Simon Horman; +Cc: Jiri Pirko, David Miller, Netdev
On Wed, Apr 29, 2015 at 11:21 PM, Simon Horman
<simon.horman@netronome.com> wrote:
> A small cleanup to make use of the ether_addr_equal helper.
>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
>
> ---
> Compile tested only
Passes my tests, thanks Simon.
Acked-by: Scott Feldman <sfeldma@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: rocker: Use ether_addr_equal
2015-04-30 6:21 [PATCH net-next] net: rocker: Use ether_addr_equal Simon Horman
2015-05-01 5:05 ` Scott Feldman
@ 2015-05-01 7:27 ` Jiri Pirko
2015-05-02 1:48 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2015-05-01 7:27 UTC (permalink / raw)
To: Simon Horman; +Cc: Scott Feldman, David Miller, netdev
Thu, Apr 30, 2015 at 08:21:29AM CEST, simon.horman@netronome.com wrote:
>A small cleanup to make use of the ether_addr_equal helper.
>
>Signed-off-by: Simon Horman <simon.horman@netronome.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: rocker: Use ether_addr_equal
2015-04-30 6:21 [PATCH net-next] net: rocker: Use ether_addr_equal Simon Horman
2015-05-01 5:05 ` Scott Feldman
2015-05-01 7:27 ` Jiri Pirko
@ 2015-05-02 1:48 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-05-02 1:48 UTC (permalink / raw)
To: simon.horman; +Cc: jiri, sfeldma, netdev
From: Simon Horman <simon.horman@netronome.com>
Date: Thu, 30 Apr 2015 15:21:29 +0900
> A small cleanup to make use of the ether_addr_equal helper.
>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-02 1:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-30 6:21 [PATCH net-next] net: rocker: Use ether_addr_equal Simon Horman
2015-05-01 5:05 ` Scott Feldman
2015-05-01 7:27 ` Jiri Pirko
2015-05-02 1:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox