[PATCH net-next] Adding switchdev ageing notification on port bridged

[PATCH net-next] Adding switchdev ageing notification on port bridged

[Elad Raz]

Configure ageing time to the HW for newly bridged device

CC: Scott Feldman <sfeldma@gmail.com>
CC: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Elad Raz <eladr@mellanox.com>
---
 net/bridge/br_stp_if.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
index 4ca449a..fa53d7a 100644
--- a/net/bridge/br_stp_if.c
+++ b/net/bridge/br_stp_if.c
@@ -15,6 +15,7 @@
 #include <linux/kmod.h>
 #include <linux/etherdevice.h>
 #include <linux/rtnetlink.h>
+#include <net/switchdev.h>
 
 #include "br_private.h"
 #include "br_private_stp.h"
@@ -35,11 +36,22 @@ static inline port_id br_make_port_id(__u8 priority, __u16 port_no)
 /* called under bridge lock */
 void br_init_port(struct net_bridge_port *p)
 {
+	struct switchdev_attr attr = {
+		.id = SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME,
+		.flags = SWITCHDEV_F_SKIP_EOPNOTSUPP | SWITCHDEV_F_DEFER,
+		.u.ageing_time = p->br->ageing_time,
+	};
+	int err;
+
 	p->port_id = br_make_port_id(p->priority, p->port_no);
 	br_become_designated_port(p);
 	br_set_state(p, BR_STATE_BLOCKING);
 	p->topology_change_ack = 0;
 	p->config_pending = 0;
+
+	err = switchdev_port_attr_set(p->dev, &attr);
+	if (err)
+		netdev_err(p->dev, "failed to set HW ageing time\n");
 }
 
 /* called under bridge lock */
-- 
2.4.3

Re: [PATCH net-next] Adding switchdev ageing notification on port bridged

[Jiri Pirko]

Mon, Oct 19, 2015 at 02:37:25PM CEST, eladr@mellanox.com wrote:
>Configure ageing time to the HW for newly bridged device
>
>CC: Scott Feldman <sfeldma@gmail.com>
>CC: Jiri Pirko <jiri@resnulli.us>
>Signed-off-by: Elad Raz <eladr@mellanox.com>

Acked-by: Jiri Pirko <jiri@mellanox.com>

Re: [PATCH net-next] Adding switchdev ageing notification on port bridged

[Scott Feldman]

On Mon, Oct 19, 2015 at 5:37 AM, Elad Raz <eladr@mellanox.com> wrote:
> Configure ageing time to the HW for newly bridged device
>
> CC: Scott Feldman <sfeldma@gmail.com>
> CC: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Elad Raz <eladr@mellanox.com>

Acked-by: Scott Feldman <sfeldma@gmail.com>

Re: [PATCH net-next] Adding switchdev ageing notification on port bridged

[David Miller]

From: Elad Raz <eladr@mellanox.com>
Date: Mon, 19 Oct 2015 15:37:25 +0300

> Configure ageing time to the HW for newly bridged device
> 
> CC: Scott Feldman <sfeldma@gmail.com>
> CC: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Elad Raz <eladr@mellanox.com>

Applied, thanks.