public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <jiri@mellanox.com>,
	<eladr@mellanox.com>, <yotamg@mellanox.com>,
	<nogahf@mellanox.com>, <ogerlitz@mellanox.com>,
	"Ido Schimmel" <idosch@mellanox.com>
Subject: [PATCH net 3/3] mlxsw: spectrum: Add missing DCB rollback in error path
Date: Thu, 4 Aug 2016 17:36:22 +0300	[thread overview]
Message-ID: <1470321382-10426-4-git-send-email-idosch@mellanox.com> (raw)
In-Reply-To: <1470321382-10426-1-git-send-email-idosch@mellanox.com>

We correctly execute mlxsw_sp_port_dcb_fini() when port is removed, but
I missed its rollback in the error path of port creation, so add it.

Fixes: f00817df2b42 ("mlxsw: spectrum: Introduce support for Data Center Bridging (DCB)")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index c3e6150..e1b8f62 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -2220,6 +2220,7 @@ err_port_vlan_init:
 err_core_port_init:
 	unregister_netdev(dev);
 err_register_netdev:
+	mlxsw_sp_port_dcb_fini(mlxsw_sp_port);
 err_port_dcb_init:
 err_port_ets_init:
 err_port_buffers_init:
-- 
2.8.2

  parent reply	other threads:[~2016-08-04 19:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 14:36 [PATCH net 0/3] mlxsw: DCB fixes Ido Schimmel
2016-08-04 14:36 ` [PATCH net 1/3] mlxsw: spectrum: Do not assume PAUSE frames are disabled Ido Schimmel
2016-08-08 16:28   ` Jiri Pirko
2016-08-04 14:36 ` [PATCH net 2/3] mlxsw: spectrum: Do not override PAUSE settings Ido Schimmel
2016-08-08 16:29   ` Jiri Pirko
2016-08-04 14:36 ` Ido Schimmel [this message]
2016-08-08 16:30   ` [PATCH net 3/3] mlxsw: spectrum: Add missing DCB rollback in error path Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470321382-10426-4-git-send-email-idosch@mellanox.com \
    --to=idosch@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=eladr@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nogahf@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox