From: Jiri Pirko <jiri@resnulli.us>
To: Ido Schimmel <idosch@mellanox.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@mellanox.com,
eladr@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com,
ogerlitz@mellanox.com
Subject: Re: [PATCH net 2/3] mlxsw: spectrum: Do not override PAUSE settings
Date: Mon, 8 Aug 2016 18:29:34 +0200 [thread overview]
Message-ID: <20160808162934.GM1944@nanopsycho.orion> (raw)
In-Reply-To: <1470321382-10426-3-git-send-email-idosch@mellanox.com>
Thu, Aug 04, 2016 at 04:36:21PM CEST, idosch@mellanox.com wrote:
>The PFCC register is used to configure both PAUSE and PFC frames.
>Therefore, when PFC frames are disabled we must make sure we don't
>mistakenly also disable PAUSE frames (which might be enabled).
>
>Fix this by packing the PFCC register with the current PAUSE settings.
>
>Note that this register is also accessed via ethtool ops, but there we
>are guaranteed to have PFC disabled.
>
>Fixes: d81a6bdb87ce ("mlxsw: spectrum: Add IEEE 802.1Qbb PFC support")
>Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2016-08-08 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 14:36 [PATCH net 0/3] mlxsw: DCB fixes Ido Schimmel
2016-08-04 14:36 ` [PATCH net 1/3] mlxsw: spectrum: Do not assume PAUSE frames are disabled Ido Schimmel
2016-08-08 16:28 ` Jiri Pirko
2016-08-04 14:36 ` [PATCH net 2/3] mlxsw: spectrum: Do not override PAUSE settings Ido Schimmel
2016-08-08 16:29 ` Jiri Pirko [this message]
2016-08-04 14:36 ` [PATCH net 3/3] mlxsw: spectrum: Add missing DCB rollback in error path Ido Schimmel
2016-08-08 16:30 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808162934.GM1944@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox