From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alex Sidorenko <alexandre.sidorenko@hpe.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion
Date: Thu, 06 Oct 2016 04:37:38 +0900 [thread overview]
Message-ID: <1475696258.28155.219.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <2440068.EFRMUI8i5V@zbook>
On Wed, 2016-10-05 at 09:06 -0400, Alex Sidorenko wrote:
> Roundrobin runner of team driver uses 'unsigned int' variable to count the number of sent_packets.
> Later it is passed to a subroutine team_num_to_port_index(struct team *team, int num) as
> 'num' and when we reach MAXINT (2**31-1), 'num' becomes negative.
>
> This leads to using incorrect hash-bucket for port lookup and as a result, packets are dropped. The fix
> consists of changing 'int num' to 'unsigned int num'. Testing of a fixed kernel shows that there
> is no packet drop anymore.
>
>
> Signed-off-by: Alex Sidorenko <alexandre.sidorenko@hpe.com>
Note that lines in your changelog are longer than the norm
( Documentation/SubmittingPatches around line 619 )
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
Otherwise, patch looks, welcome to the club Alex !
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2016-10-05 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 22:30 A bug in team driver Alex Sidorenko
2016-10-05 3:08 ` Eric Dumazet
2016-10-05 13:06 ` [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion Alex Sidorenko
2016-10-05 19:37 ` Eric Dumazet [this message]
2016-10-06 5:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475696258.28155.219.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=alexandre.sidorenko@hpe.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox